Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade element actions core #1930

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Conversation

MohabMohie
Copy link
Contributor

No description provided.

- upgrade hover
- upgrade click and hold
- upgrade double click
- upgrade set value using javascript
- upgrade drag and drop by offset
- upgrade get().selectedText
- delete ElementAction.java
- remove unused code
- remove previously deprecated methods
- no more actions performed inside ElementActionsHelper.java
- remove invalid tests
@MohabMohie MohabMohie merged commit 60f74dc into main Mar 9, 2025
14 of 15 checks passed
@MohabMohie MohabMohie deleted the element-actions-core-upgrades branch March 9, 2025 22:48
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 34.04255% with 31 lines in your changes missing coverage. Please review.

Project coverage is 52.55%. Comparing base (d1ba82f) to head (d89e4d4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/com/shaft/gui/element/internal/Actions.java 32.43% 24 Missing and 1 partial ⚠️
...ain/java/com/shaft/gui/element/ElementActions.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1930      +/-   ##
============================================
- Coverage     53.17%   52.55%   -0.62%     
+ Complexity     1472     1398      -74     
============================================
  Files           116      115       -1     
  Lines         10791    10509     -282     
  Branches       1054     1021      -33     
============================================
- Hits           5738     5523     -215     
+ Misses         4388     4337      -51     
+ Partials        665      649      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant