Skip to content

Commit

Permalink
Update outdated comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sharparam committed Sep 6, 2024
1 parent 994cbc0 commit 26e9a38
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions KillTrack.lua
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ function KT.Events.COMBAT_LOG_EVENT_UNFILTERED(self)
local _, event, _, s_guid, _, _, _, d_guid, d_name, _, _ = CombatLogGetCurrentEventInfo()
if combat_log_damage_events[event] then
if FirstDamage[d_guid] == nil then
-- s_name is (probably) the player who first damaged this mob and probably has the tag
-- s_guid is (probably) the player who first damaged this mob and probably has the tag
FirstDamage[d_guid] = s_guid
end

Expand Down Expand Up @@ -313,8 +313,7 @@ function KT.Events.COMBAT_LOG_EVENT_UNFILTERED(self)
local lastByPlayer = lastDamage == self.PlayerGUID or lastDamage == UnitGUID("pet")
local pass

-- All checks after DamageValid should be safe to remove
-- The checks after DamageValid are also not 100% failsafe
-- The checks after DamageValid are not 100% failsafe
-- Scenario: You deal the killing blow to an already tapped mob <- Would count as kill with current code

-- if DamageValid[guid] is set, it can be used to decide if the kill was valid with 100% certainty
Expand Down

0 comments on commit 26e9a38

Please sign in to comment.