Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix site style to better align icons #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix site style to better align icons #3

wants to merge 1 commit into from

Conversation

itsbth
Copy link

@itsbth itsbth commented Aug 18, 2023

Still not 100%, but way better.
Before:
image
After:
image

@itsbth
Fix site style to better align icons
d768a4a 
Still not 100%, but way better.
@itsbth itsbth requested a review from Sharparam as a code owner August 18, 2023 13:25
Sharparam
Sharparam requested changes Aug 18, 2023
View reviewed changes
Copy link
Owner

@Sharparam Sharparam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes this looks much better. The GitHub icon seems to have the reverse problem of being too far down now though.

Can you add some spacing between the icons and the text also? Then it'll be perfect to merge!

@Sharparam Sharparam added the documentation Improvements or additions to documentation label Aug 18, 2023
@Sharparam Sharparam self-assigned this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharparam Sharparam Sharparam requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Sharparam Sharparam

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsbth @Sharparam