sahar/profile-page-desktop #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edit button positioning within the ExperienceCard component has been modified. Previously, it was placed outside the "experience-card-edit-section" div. Now, it's included inside this div to improve organization and code structure. The conditional rendering remains the same, only displayed for the profile owner with a valid authentication token.
Enhanced the styling for the Profile Page and the Experience Card components by altering CSS properties. Updates include creating a bio-section in the profile page and altering size specifications in the experience card container to be more responsive. Additionally, unneeded components or styling such as the 'hr' element and an unused link import in ExperienceCard.jsx have been removed for cleaner code. Media queries in component and application level CSS have also been updated for better responsiveness.
Sahar-Kavousi
requested review from
awesomeann,
blakerach1,
ktechgau,
Lyndallh and
shayzimm
shayzimm
approved these changes
Apr 7, 2024
blakerach1
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update profile page and experience card styles
Enhanced the styling for the Profile Page and the Experience Card components by altering CSS properties. Updates include creating a bio-section in the profile page and altering size specifications in the experience card container to be more responsive. Additionally, unneeded components or styling such as the 'hr' element and an unused link import in ExperienceCard.jsx have been removed for cleaner code. Media queries in component and application level CSS have also been updated for better responsiveness.
Type of change
What kind of feedback do you need?
need a quick look
Checklist: