Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karla/hide functions #104

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Karla/hide functions #104

merged 3 commits into from
Apr 7, 2024

Conversation

ktechgau
Copy link
Collaborator

@ktechgau ktechgau commented Apr 7, 2024 •
edited
Loading

Describe your changes

Hide functions in play:

  • When profile has no tags or industries, those sections do not appear.
  • When profile has not added any experiences, a notice indicating this profile has no experiences to show appears.
  • If profile has no experience cards, "This profile has no experiences to display at the moment" will be displayed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

What kind of feedback do you need?

E.g. Do you need a quick look or a thorough assessment?

Checklist:

  • I have performed a self-review of my code
  • I have recommended where to start and how to proceed with the review
  • I have done a git pull from DEV to ensure this PR is up to date

blakerach1
blakerach1 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@blakerach1 blakerach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Working

@ktechgau ktechgau merged commit c10b0fe into DEV Apr 7, 2024
2 checks passed
@blakerach1 blakerach1 deleted the karla/hide-functions branch April 7, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerach1 blakerach1 blakerach1 approved these changes

@Sahar-Kavousi Sahar-Kavousi Sahar-Kavousi approved these changes

@awesomeann awesomeann Awaiting requested review from awesomeann

@shayzimm shayzimm Awaiting requested review from shayzimm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktechgau @blakerach1 @Sahar-Kavousi