This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(app): add dynamic translation to agent detail form #311
Merged
pratimasakinala
merged 21 commits into
ps-locale-translation
from
310-ebg-add-dynamic-translation-to-agent-detail-form
Apr 8, 2021
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ae28b68
fix(title): reference correct value
Karvel e96b8a5
feat(resolvers): initialize new agent object with dynamic content
Karvel cbc0150
test(update-agent): add dependencies
Karvel f8e78c6
style(app): reorder statements, clean up aliases
Karvel ed89044
feat(i18n, title): add `setTranslation`, translations
Karvel f47e60c
feat, refactor(agents): use event emitter instead of state for trigger
Karvel 8f3a929
feat(models, dynamic-form): add and bind `formTitleParams` to template
Karvel fcd9e06
feat(agent-detail): add `isSetTranslation` boolean
Karvel 029d44a
feat(agent-detail): disable form control based on `isSetTranslation`
Karvel 7005891
feat(agent-detail): update submit action based on conditions
Karvel 482a80a
feat(agent-detail): map selected language to form
Karvel 8bcd2b1
feat(agent-detail): set form name and params
Karvel 8fc1ca9
test(agent-detail): add test dependencies
Karvel 33f7580
feat(content-routing): wire up `set-translation/:id/:languageCode` route
Karvel 930c0b8
refactor(agent): improve typing
Karvel 742c463
feat(content, i18n): add translation for `set-translation` route name
Karvel b0ef512
refactor(content-routing): adds HasValidLanguageGuard to `set-transla…
pratimasakinala 35a5db9
feat(agent-detail, dynamic-form-action, JSONs): creates a new propert…
pratimasakinala e1607b7
refactor(form-input, form-select): reads formControl from the `group.…
pratimasakinala b8fb2a7
refactor(agent): removes description property from agent dto since it…
pratimasakinala b231e24
chore(agent-detail): adds TODO to send request to the server to set T…
pratimasakinala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function seems to just call
this.buildPayload()
, could we just call that here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That functionality isn't in yet. The method is essentially noop right now. We decided to handle the mapping of the data into the payload in a separate branch so we could merge this while the API catches up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Karvel Got it, thank you!