This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
feat(agent): Creates payload and request to create/update translations for agents #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds in the Agent Service to create & update translations for an agent. These methods are consumed in the agent-detail component by passing appropriate payload. Writes tests for the new methods in the agent service. creates a new interface for IAgentTranslationRequest that is used as the payload type while setting translation. creates `translationCreated` & `translationUpdated` translation keys in INotificationTranslationKey. Adds these new translation keys in the languauge JSON files.
pratimasakinala
added
the
feature
pratimasakinala
requested review from
a team,
michaelachrisco,
gyuhunlee,
vinsonf,
Karvel,
AramayisO and
mwallert
and removed request for
Karvel,
mwallert and
a team
michaelachrisco
approved these changes
Apr 20, 2021
Comment on lines
+254
to
+256
| translationForLanguage.hasTranslation | ||
| ? this.updateTranslation(translationPayload) | ||
| : this.createTranslation(translationPayload); |
There was a problem hiding this comment.
What happens if we trigger setTranslation and it actually goes not contain any changes?
There was a problem hiding this comment.
Apologies for the delayed response. Do you mean the form values don't change? The client will send a request to the server regardless of whether or not the payload value changes.
…when the language requested isnt part of the agent data.
AramayisO
approved these changes
Apr 28, 2021
…reEach` description
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IAgentTranslationRequestthat is used as the payload type while setting translation.translationCreated&translationUpdatedtranslation keys inINotificationTranslationKey.Purpose
Send requests to the server to create/update the agent translation as described in #318
Approach
The frontend sends requests to the new POST & PUT endpoints
agent/:id/translationsas defined here to create/update the translations.Testing Steps
If you are not a member of this project, skip this step
Descriptionvalue in the form.agent/:id/translationsendpoint using a POST method.dynamicContentobject including all languages that have translations available.Closes #318