Manual update to help Long Term Maintenance #359

22antonio · 2021-11-10T01:26:09Z

Changes

Updated SpecReporter syntax
Update Docker node version from 10 to 12
Update Angular/Angular dependencies
Updated npm packages
Added EsLint as new linter

Purpose

This manual update should help with some of the maintenance of the project.

Learning

Working example of jasmine-spec-reporter
Protractor is deprecated
TsLint is deprecated, EsLint is the replacement
ESLint v5 is not supported by angular right now

Fixes #340

This reverts commit 90101e4.

22antonio · 2021-11-17T23:42:10Z

commit 62dee66 should be chore(deps)... not chore(docker)... .

mwallert · 2021-11-18T21:29:00Z

@michaelachrisco It looks like development and main are out of sync for codeowners. I'm not sure I will have time to get to this PR before EOD and I'm out next week.

michaelachrisco · 2021-11-18T21:30:47Z

@mwallert Thanks for letting me know. @22antonio Lets go over this on Monday. Looks like we may need to prune this real quick. Ill remove @mwallert from the PR and assign myself in place.

michaelachrisco · 2021-11-18T21:31:47Z

I cant remove you 😆 So Ill just add myself for now. And get to that CODEOWNERS/dev->main up to date branches.

michaelachrisco · 2021-11-18T21:33:22Z

commit 62dee66 should be chore(deps)... not chore(docker)... .

Its all good. Next time, I would suggest using git rebase to change the git commit messages. No worries here.

michaelachrisco · 2021-11-22T18:21:56Z

As we discussed, @22antonio will be taking a look at the UI and finding out if the features are working. He will also include a screenshot of a logged in session just to make sure. After that, this should be good!

michaelachrisco

As we discussed, @22antonio will be taking a look at the UI and finding out if the features are working. He will also include a screenshot of a logged in session just to make sure. After that, this should be good!

@22antonio Let me know when this is finished and we can take a quick second look. Thanks!

22antonio · 2021-11-23T18:45:17Z

I pushed some updates to fix the incompatibility issues I was having with the newer version of node and angular.
I was able to:

Manually add users and agents.
Directories would update as they should.
Login as other users not just seeded.
Password checking worked.

Login screenshot you requested:

michaelachrisco · 2021-11-23T21:13:37Z

@22antonio Awesome job here!! Looks great. Can you do me a favor and update the README with the correct versions of the Angular CLI? https://github.com/Shift3/boilerplate-client-angular/blob/main/README.md Looks like the readme references v9.

michaelachrisco

Pulled down the repo, looks like everything is working to what I can see. Awesome job here @22antonio ! Non-blocker but I if you could update the README with the correct versions that would help out as well.

AramayisO

Great job on this PR. Good to see the project updated to use the latest versions of the Angular CLI and updated version of Node.

One question regarding the CircleCI config.yml. I believe the newer version of Angular CLI specifically requires Node version 14.15. The CI config specifies to use the circleci/node:14-browsers image. Is it possible to restrict it to version 14.15 so it doesn't use a newer version of Node 14 and cause the Angular CLI to throw an error?

src/app/app.component.spec.ts

AramayisO · 2021-11-23T21:21:47Z

.circleci/config.yml

@@ -3,7 +3,7 @@ jobs:
  test:
    working_directory: ~/boilerplate-client-angular
    docker:
-      - image: 'circleci/node:10-browsers'
+      - image: 'circleci/node:14-browsers'


Nice! We were pretty behind on the node version.

One question, since the new version of Angular CLI requires Node v14.15, can we restrict the image here to 14.15 so it doesn't pull a newer version of node 14.* and cause CI to fail?

Thank you for the suggestion. I just pushed up a change to enforce the specific version. It looks like it works 👍

AramayisO · 2021-11-23T21:27:02Z

src/environments/environment.test.ts

+import * as packageInfo from '../../package.json';
+const { name, version } = packageInfo;


Not a blocker, but is there a reason for importing everything from package.json instead of deestructuring just what we need?

I was getting an error when trying to access package variables that way. I don't recall the error though I'll have to find it for you.

I believe this is no longer the way to access package.json variables. It has been deprecated

Interesting. I'll have to look into it as well because we are still doing it the old way in the React boilerplate.

src/environments/environment.ts

22antonio · 2021-11-24T00:53:27Z

@michaelachrisco

Pulled down the repo, looks like everything is working to what I can see. Awesome job here @22antonio ! Non-blocker but I if you could update the README with the correct versions that would help out as well.

I just updated the README with the correct version of Angular CLI. While I was looking at it I noticed that it still has a section talking about Protractor. Since Protractors been deprecated how should I handle that part of the README?

michaelachrisco · 2021-11-24T15:28:33Z

@michaelachrisco

Pulled down the repo, looks like everything is working to what I can see. Awesome job here @22antonio ! Non-blocker but I if you could update the README with the correct versions that would help out as well.

I just updated the README with the correct version of Angular CLI. While I was looking at it I noticed that it still has a section talking about Protractor. Since Protractors been deprecated how should I handle that part of the README?

Are we still using it within our testing suite? Unless its been completely stripped out, lets keep that section for now. If not, lets remove.

22antonio · 2021-11-24T20:03:35Z

I left it since we don't have a proper replacement yet. In this case I think it should get removed when we complete #365

22antonio added 2 commits November 9, 2021 16:57

chore(protractor): update SpecReporter syntax

d375dd0

chore(deps): unbreaking minor and patch updates

468baaa

22antonio added the dependencies Pull requests that update a dependency file label Nov 10, 2021

22antonio added 15 commits November 10, 2021 15:25

fix(ci): update ci docker image to node 12 from 10

0040b11

chore(angular): update angular from 9.x to 10.x

a8ac4d0

chore(angular): update angular from 10.x to 11.x

2f852db

chore(angular): update angular from 11.x to 12.x

2d26d16

chore(angular): update angular from 12.x to 13.x

073d8e6

fix(env.ts): update deprecated package.json access

c7e87f3

fix(env.test.ts): properly import package.json dep

40c2900

fix(linter): convert deprecated tslint to eslint

396a86d

chore(deps): update packages major release

80432a0

chore(docker): install angular/[email protected]

aa9cd5f

chore(deps): install angular/[email protected]

ce0c69e

chore(docker): update karma, sentry, pretty-quick to latest

62dee66

fix(deps): eslint5 unsupported reduced to 4.33.0

90101e4

Revert "fix(deps): eslint5 unsupported reduced to 4.33.0"

40b0dd0

This reverts commit 90101e4.

fix(deps): eslint5 unsupported reduced to stable

a9063d0

22antonio marked this pull request as ready for review November 17, 2021 23:40

22antonio requested a review from mwallert as a code owner November 17, 2021 23:40

22antonio requested review from a team, aneshamoore and gyuhunlee and removed request for a team November 17, 2021 23:40

22antonio changed the title ~~Am 340 long term maintenance~~ Manual update to help Long Term Maintenance Nov 18, 2021

michaelachrisco self-requested a review November 18, 2021 21:32

michaelachrisco assigned 22antonio Nov 18, 2021

michaelachrisco suggested changes Nov 23, 2021

View reviewed changes

22antonio added 2 commits November 23, 2021 10:39

fix(dep): compatible version of node & angular

8498684

chore(ci): update ci to match nodev14 in project

f268519

22antonio requested a review from AramayisO as a code owner November 23, 2021 18:41

michaelachrisco approved these changes Nov 23, 2021

View reviewed changes

AramayisO approved these changes Nov 23, 2021

View reviewed changes

22antonio added 2 commits November 23, 2021 16:36

chore(ci): enforce node version to prevent failure

e5af424

chore(README): update angular cli 9.1.5 to 13.0.2

2c9adc2

22antonio merged commit 1b2eafc into development Nov 24, 2021

22antonio deleted the am-340-long-term-maintenance branch November 24, 2021 20:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manual update to help Long Term Maintenance #359

Manual update to help Long Term Maintenance #359

22antonio commented Nov 10, 2021 •

edited

Loading

22antonio commented Nov 17, 2021

mwallert commented Nov 18, 2021

michaelachrisco commented Nov 18, 2021

michaelachrisco commented Nov 18, 2021

michaelachrisco commented Nov 18, 2021

michaelachrisco commented Nov 22, 2021

michaelachrisco left a comment

22antonio commented Nov 23, 2021

michaelachrisco commented Nov 23, 2021

michaelachrisco left a comment

AramayisO left a comment

AramayisO Nov 23, 2021

22antonio Nov 24, 2021

AramayisO Nov 23, 2021

22antonio Nov 24, 2021

22antonio Nov 24, 2021

AramayisO Nov 24, 2021

22antonio commented Nov 24, 2021

michaelachrisco commented Nov 24, 2021 •

edited

Loading

22antonio commented Nov 24, 2021

		import * as packageInfo from '../../package.json';
		const { name, version } = packageInfo;

Manual update to help Long Term Maintenance #359

Manual update to help Long Term Maintenance #359

Conversation

22antonio commented Nov 10, 2021 • edited Loading

Changes

Purpose

Learning

22antonio commented Nov 17, 2021

mwallert commented Nov 18, 2021

michaelachrisco commented Nov 18, 2021

michaelachrisco commented Nov 18, 2021

michaelachrisco commented Nov 18, 2021

michaelachrisco commented Nov 22, 2021

michaelachrisco left a comment

Choose a reason for hiding this comment

22antonio commented Nov 23, 2021

michaelachrisco commented Nov 23, 2021

michaelachrisco left a comment

Choose a reason for hiding this comment

AramayisO left a comment

Choose a reason for hiding this comment

AramayisO Nov 23, 2021

Choose a reason for hiding this comment

22antonio Nov 24, 2021

Choose a reason for hiding this comment

AramayisO Nov 23, 2021

Choose a reason for hiding this comment

22antonio Nov 24, 2021

Choose a reason for hiding this comment

22antonio Nov 24, 2021

Choose a reason for hiding this comment

AramayisO Nov 24, 2021

Choose a reason for hiding this comment

22antonio commented Nov 24, 2021

michaelachrisco commented Nov 24, 2021 • edited Loading

22antonio commented Nov 24, 2021

22antonio commented Nov 10, 2021 •

edited

Loading

michaelachrisco commented Nov 24, 2021 •

edited

Loading