feat(ios-deploy): iOS Specific Instructions on Deployments #291
Conversation
michaelachrisco
changed the title
michaelachrisco
force-pushed
the
mac-278-ios-deploy
branch
from
6904ce3 to
d53c15d
Compare
michaelachrisco
changed the title
michaelachrisco
changed the title
michaelachrisco
requested review from
a team,
JamesVal and
aneshamoore
and removed request for
a team
michaelachrisco
changed the title
|
Added @Basim-Elayan and @Endtry whom both have experience in this field. |
| - Make sure 'V1' and 'V2' Signature Versions are both checked. | ||
| - Click 'finish' | ||
| - After it's done, the APK will be available in the APK Destination Folder | ||
| 1. Open the xcode workspace project. |
There was a problem hiding this comment.
Not sure if we need to mention anything about Signing team, background modes (Capabilities)
There was a problem hiding this comment.
Thanks for the feedback!
I thought signing happens automatically now within xcode? Or are we talking about a different Signing process?
Do we have a good reference on the background modes? Are you talking about the permissions that we had to set up on the app?
There was a problem hiding this comment.
Based on the current application required permissions like Bluetooth or remote notifications etc...
There was a problem hiding this comment.
Here I meant just to mention that with no details as a note. Not sure though if we need it.
| 1. Open the xcode workspace project. | ||
| 2. In upper left-hand of screen, click on `Generic iOS Device`. Select a device you'd like to test on. | ||
| 3. Build the app via the play button. Be sure the iOS device is set to a physical apple device | ||
| <img width="399" alt="Screen Shot 2021-07-30 at 2 23 02 PM" src="https://user-images.githubusercontent.com/25145605/127720045-664ec7b6-95e1-43b5-af55-9938b5c10c5d.png"> |
There was a problem hiding this comment.
Very helpful images. Nice job.
There was a problem hiding this comment.
I believe most of these images were added by @gabymoreno9. We pushed for more docs within the Sundial repo and it did help out later on. I just pulled them all in here and organized a bit.
Changes
Purpose
To correct and and more information on iOS deploys. To alleviate some of the pain of deployment.
Approach
For some reason, we had our Android Deployment procedures twice within the repo. I went ahead and removed that as well as added known good instructions with lots of screenshots from one of our internal projects.
Learning
We learned a lot from deploying in both iOS and Android with react native recently. Some of these lessons included making sure everything is documented which should include our S&P repo.
If anyone has any other examples they would like to share, let us know within this PR or parent issue! More examples will make this easier in the future.
Closes #278
Related to #88