Skip to content

Commit

Permalink
update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
mgaitan committed Aug 6, 2024
1 parent e3aae63 commit 1bd3862
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ Check the [internal docs](https://docs.shiphero.xyz/ci.html#horizontally-scaled-
This minimizes the chance of the `InsufficientInstanceCapacity` error, by balancing and trying
subnetworks in different subzones

- [Reduce the waiting and polling intervals](https://github.com/Shiphero/ec2-github-runner/blob/97e4566a338e61490ce0a5b944e62801041faccb/src/gh.js#L63) for the runners registering.
- <strike>[Reduce the waiting and polling intervals](https://github.com/Shiphero/ec2-github-runner/blob/97e4566a338e61490ce0a5b944e62801041faccb/src/gh.js#L63) for the runners registering.

This allows to save around 45' on the "start" step. </strike>

Reverted in 5659035ee505 because we was hitting Github rate limits for personal tokens.

- [Increases the page size when listing runners](https://github.com/Shiphero/ec2-github-runner/pull/2/commits/e3aae63b6a8bd136b0fd9460468dc85097a8d273) to reduce the number or requests to Github API.

This allows to save around 45' on the "start" step.
4 changes: 2 additions & 2 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -65473,8 +65473,8 @@ const github = __webpack_require__(95438);
const _ = __webpack_require__(90250);
const config = __webpack_require__(34570);

// use the unique label to find the runner
// as we don't have the runner's id, it's not possible to get it in any other way
// use the unique label to find the runners
// as we don't have the runners ids, it's not possible to get them in any other way
async function getRunners(label) {
const octokit = github.getOctokit(config.input.githubToken);

Expand Down

0 comments on commit 1bd3862

Please sign in to comment.