-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out small community detection #51
Open
ahill187
wants to merge
211
commits into
ShobiStassen:master
Choose a base branch
from
ahill187:small-communities
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix simplicial set embedding bug
Add logging
Code cleanup
`func_mode` -> `get_mode`
Factor out large community expansion
14 tasks
ahill187
changed the title
Factor out small community reassignment
Factor out small community detection
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have factored out the code that merges small communities. There was a lot of duplicated code between
fit_predict
andrun_toobig_subPARC
, so this addressed that issue.I have created three new functions:
small_community_merging
: This function runs the merging functionality, with help from the other two functions.get_small_communities
: A helper function to find which communities are too small.reassign_small_communities
: A helper function which iteratively reassigns the small communities to other communities.I have renamed several of the variables:
population
is ambiguous, it could be a single value or a setPARC
is not only used for cells; it can take any type of dataold
as a modifier is poor practicenode_communities
Type of Change
Tests
tests/test_parc.py: test_parc_get_small_communities
tests/test_parc.py: test_parc_reassign_small_communities
tests/test_parc.py: test_parc_small_community_merging
Linked PRs / Issues
ahill187#29
Checklist: