Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <Static /> in app logs command to better support paging #4395

Closed
wants to merge 3 commits into from

Conversation

nickwesselman
Copy link
Contributor

  • Moved polling errors inline with logs to support this

This PR will remain draft until Ink merges this and we update our version:
vadimdemedes/ink#669

WHY are these changes introduced?

With ink supporting piped output, the app logs command can be used with pagers such as | less and | more. But we need to use <Static /> to support live/streaming output when there is no TTY.

WHAT is this pull request doing?

  • Updates the app logs UI to use <Static />
  • Moves polling errors inline with log output, so that they stream together

How to test your changes?

Use shopify app logs on its on and with a pager, e.g. shoping app logs | more.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

* Moved polling errors inline with logs to support this
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant