Use <Static /> in app logs command to better support paging #4395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remain draft until Ink merges this and we update our version:
vadimdemedes/ink#669
WHY are these changes introduced?
With ink supporting piped output, the
app logs
command can be used with pagers such as| less
and| more
. But we need to use<Static />
to support live/streaming output when there is no TTY.WHAT is this pull request doing?
app logs
UI to use<Static />
How to test your changes?
Use
shopify app logs
on its on and with a pager, e.g.shoping app logs | more
.Measuring impact
How do we know this change was effective? Please choose one:
Checklist