Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make set up cookie banner by default to false #2588

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Oct 4, 2024

Breaking change

Set up Customer Privacy without the Shopify's cookie banner by default.

Upgrade instructions

If you are using Shopify's cookie banner to handle user consent in your app, you need to set withPrivacyBanner: true to the consent config. Without this update, the Shopify cookie banner will not appear.

  return defer({
    ...
    consent: {
      checkoutDomain: env.PUBLIC_CHECKOUT_DOMAIN,
      storefrontAccessToken: env.PUBLIC_STOREFRONT_API_TOKEN,
+      withPrivacyBanner: true,
      // localize the privacy banner
      country: args.context.storefront.i18n.country,
      language: args.context.storefront.i18n.language,
    },
  });

PR description

WHY are these changes introduced?

We need to make setting up Shopify cookie banner by default to false.

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Oct 4, 2024

Oxygen deployed a preview of your hl-default-privacy-false branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 5:19 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 5:18 PM
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 5:19 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 5:19 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 5:19 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 5:19 PM

Learn more about Hydrogen's GitHub integration.

@rbshop rbshop added the 2024.10 label Oct 18, 2024
@wizardlyhel wizardlyhel merged commit a253ef9 into main Oct 21, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-default-privacy-false branch October 21, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants