Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analytic provider breaking after a 404 page #2590

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Fix analytic provider breaking after a 404 page #2590

merged 3 commits into from
Oct 4, 2024

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

Fixes: #2576

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@shopify Shopify
Copy link
Contributor

shopify bot commented Oct 4, 2024 •
edited
Loading

Oxygen deployed a preview of your hl-404-analytics-fix branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 9:41 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 9:41 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 9:41 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 9:50 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 9:41 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment October 4, 2024 9:41 PM

Learn more about Hydrogen's GitHub integration.

@wizardlyhel wizardlyhel mentioned this pull request Oct 4, 2024
Closed
@wizardlyhel wizardlyhel merged commit d08d8c3 into main Oct 4, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-404-analytics-fix branch October 4, 2024 21:51
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Oct 4, 2024
Merged
This was referenced Oct 10, 2024
Closed
Closed
Closed
This was referenced Oct 21, 2024
Closed
Closed
This was referenced Oct 28, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpprieto juanpprieto juanpprieto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 (Not Found) pages break Analytics
2 participants
@wizardlyhel @juanpprieto