Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump body-parser, graphql codegen, semver, ws packages #2776

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bump body-parser, graphql codegen, semver, ws packages #2776

wants to merge 5 commits into from
+123 −113

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@shopify Shopify
Copy link
Contributor

shopify bot commented Feb 24, 2025 •
edited
Loading

Oxygen deployed a preview of your hl-bump-packages-1 branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment February 24, 202510:53 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment February 24, 202510:53 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment February 24, 202510:53 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment February 24, 202510:53 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment February 24, 202510:53 PM

Learn more about Hydrogen's GitHub integration.

@wizardlyhel wizardlyhel changed the title Bumo body-parser and graphql codegen Bump body-parser and graphql codegen Feb 24, 2025
@wizardlyhel wizardlyhel changed the title Bump body-parser and graphql codegen Bump body-parser, graphql codegen, semver, ws packages Feb 24, 2025
rbshop
rbshop reviewed Feb 25, 2025
View reviewed changes
packages/hydrogen/src/csp/Script.test.ts
Comment on lines +31 to +33
>
</script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unintended

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The match inline snapshots were failing. I had to remove older version of happy-dom in the package-lock cause it was being used even tho I update to use a newer version of happy-dom awhile back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbshop rbshop rbshop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wizardlyhel @rbshop