Skip to content

Commit

Permalink
Adds WithoutRouterTest
Browse files Browse the repository at this point in the history
Co-Authored-By: Hartley McGuire <[email protected]>
  • Loading branch information
Schwad and skipkayhil committed Mar 6, 2025
1 parent 52f95ec commit 051743c
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 0 deletions.
24 changes: 24 additions & 0 deletions actionpack/test/controller/base_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,30 @@ def action_missing(action)
end
end

class WithoutRouterController < ActionController::Base
# Regression test for https://github.com/rails/rails/commit/7df1b84335298140116a59cad1bffea6c6a91747
after_action :log_request_details

def index
head :ok
end

private
def log_request_details
request.route_uri_pattern
end
end

class WithoutRouterTest < ActionController::TestCase
tests CallbackRequestAvailabilityController

def test_request_available_in_after_action_callback
assert_nothing_raised do
get :index
end
end
end

class ControllerClassTests < ActiveSupport::TestCase
def test_controller_path
assert_equal "empty", EmptyController.controller_path
Expand Down
20 changes: 20 additions & 0 deletions bisect_log.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
git bisect start
# status: waiting for both good and bad commits
# bad: [7df1b84335298140116a59cad1bffea6c6a91747] Merge pull request #54541 from Shopify/report-option-retry-on
git bisect bad 7df1b84335298140116a59cad1bffea6c6a91747
# status: waiting for good commit(s), bad commit known
# good: [3ff8c45e7b525c6b947d6f4f3350366b0d7e97ed] Add `report:` option to `ActiveJob::Base#retry_on` and `#discard_on`
git bisect good 3ff8c45e7b525c6b947d6f4f3350366b0d7e97ed
# bad: [8e504b017a68981076746c2d19fd23c788e4293e] Merge pull request #54530 from byroot/update-all-extra-test
git bisect bad 8e504b017a68981076746c2d19fd23c788e4293e
# good: [daf5e97c35ff83a8cb197f4f5053c3a519ca1def] Merge pull request #54506 from dkani/main
git bisect good daf5e97c35ff83a8cb197f4f5053c3a519ca1def
# bad: [9e3829804ce67ed15385b57aa2bda289d52f557b] Merge pull request #54526 from skipkayhil/hm-avoid-array-methods
git bisect bad 9e3829804ce67ed15385b57aa2bda289d52f557b
# good: [4a90c7ad24ae0fb48eaeae2729bfa1ad58a585be] Check constraints exist before call `#any?`
git bisect good 4a90c7ad24ae0fb48eaeae2729bfa1ad58a585be
# good: [e6175dfb07e386b7e22b8b4980e22d0f2481fc50] Only iterate path_parameters once
git bisect good e6175dfb07e386b7e22b8b4980e22d0f2481fc50
# good: [cc7c359e313d255f1ed6b40c5010378b04707e98] Reorder equality so happy path hits `Nil#==`
git bisect bad cc7c359e313d255f1ed6b40c5010378b04707e98
# first bad commit: [9e3829804ce67ed15385b57aa2bda289d52f557b] Merge pull request #54526 from skipkayhil/hm-avoid-array-methods

0 comments on commit 051743c

Please sign in to comment.