Merge pull request rails#53882 from Shopify/sqlite-use-default-function

SQLite3: Use default function as default insert value

activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb

@@ -138,7 +138,11 @@ def returning_column_values(result)
           end
 
           def default_insert_value(column)
-            column.default
+            if column.default_function
+              Arel.sql(column.default_function)
+            else
+              column.default
+            end
           end
       end
     end

activerecord/test/cases/fixtures_test.rb

@@ -6,6 +6,7 @@
 require "models/admin/account"
 require "models/admin/randomly_named_c1"
 require "models/admin/user"
+require "models/aircraft"
 require "models/author"
 require "models/binary"
 require "models/book"
@@ -112,8 +113,6 @@ def test_bulk_insert_multiple_table_with_a_multi_statement_query
     end
 
     def test_bulk_insert_with_a_multi_statement_query_raises_an_exception_when_any_insert_fails
-      require "models/aircraft"
-
       assert_equal false, Aircraft.columns_hash["wheels_count"].null
       fixtures = {
         "aircraft" => [
@@ -478,6 +477,20 @@ def test_insert_with_datetime
     assert first
   end
 
+  def test_insert_with_default_function
+    create_fixtures("aircrafts")
+
+    aircraft = Aircraft.find_by(name: "boeing-with-no-manufactured-at")
+    assert_equal Time.now.utc.strftime("%Y-%m-%d %H:%M:%S"), aircraft.manufactured_at.strftime("%Y-%m-%d %H:%M:%S")
+  end
+
+  def test_insert_with_default_value
+    create_fixtures("aircrafts")
+
+    aircraft = Aircraft.find_by(name: "boeing-with-no-wheels")
+    assert_equal 0, aircraft.wheels_count
+  end
+
   def test_logger_level_invariant
     previous_logger = ActiveRecord::Base.logger
     ActiveRecord::Base.logger = ActiveSupport::Logger.new(nil)

activerecord/test/fixtures/aircrafts.yml

@@ -0,0 +1,7 @@
+no_wheels:
+  name: boeing-with-no-wheels
+  manufactured_at: 2024-01-01
+
+no_manufactured_at:
+  name: boeing-with-no-manufactured-at
+  wheels_count: 2