Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document custom bundle process #2615

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Document custom bundle process #2615

merged 3 commits into from
Sep 30, 2024

Conversation

vinistock
Copy link
Member

Motivation

This PR documents the custom bundle process, which was missing from our docs.

@vinistock vinistock added the documentation Improvements or additions to documentation label Sep 24, 2024
@vinistock vinistock self-assigned this Sep 24, 2024
@vinistock vinistock requested a review from a team as a code owner September 24, 2024 17:41
andyw8
andyw8 reviewed Sep 25, 2024
View reviewed changes
jekyll/index.markdown Outdated Show resolved Hide resolved
@andyw8
Copy link
Contributor

andyw8 commented Sep 25, 2024

Do we want to also mention that the custom bundle ensures we are using the versions of dependencies as the main bundle?

@vinistock vinistock requested a review from andyw8 September 30, 2024 14:34
@vinistock vinistock force-pushed the vs-document-custom-bundle branch from 61481cb to bb2f5d0 Compare September 30, 2024 15:03
@vinistock vinistock enabled auto-merge (squash) September 30, 2024 15:04
@andyw8
Copy link
Contributor

andyw8 commented Sep 30, 2024

(for consistency we should later update the code to also use the term 'composed').

@vinistock vinistock merged commit 4df5ddf into main Sep 30, 2024
36 checks passed
@vinistock vinistock deleted the vs-document-custom-bundle branch September 30, 2024 15:23
@andyw8 andyw8 mentioned this pull request Oct 17, 2024
Merged
alexcrocha
alexcrocha reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@alexcrocha alexcrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to add that this documentation was quite helpful to understand what the composed process is and why we need it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrocha alexcrocha alexcrocha left review comments

@andyw8 andyw8 andyw8 approved these changes

Assignees

@vinistock vinistock

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinistock @andyw8 @alexcrocha