Prevent relative require completion from failing on permissions #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
andyw8
approved these changes
Feb 7, 2025
Merge activity
|
### Motivation We have some cases in our telemetry where the user typed in a relative require pointing to a directory that the editor doesn't have permission to read. This will cause an `Errno::EPERM` and currently makes completion crash. ### Implementation Started rescuing the error. If we can't read the directory, we can't list files. ### Automated Tests I tried writing a test for this, but for some reason removing all permissions with `FileUtils.chmod` doesn't reproduce. Glob just returns an empty array instead. Not sure if the behaviour is platform specific, but rather than spending a disproportionate amount of effort writing this one test, I think it's safe to just rescue.
graphite-app
bot
force-pushed
the
02-07-prevent_relative_require_completion_from_failing_on_permissions
branch
from
c1ceb26 to
1a38cbc
Compare
graphite-app
bot
deleted the
02-07-prevent_relative_require_completion_from_failing_on_permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some cases in our telemetry where the user typed in a relative require pointing to a directory that the editor doesn't have permission to read.
This will cause an
Errno::EPERMand currently makes completion crash.Implementation
Started rescuing the error. If we can't read the directory, we can't list files.
Automated Tests
I tried writing a test for this, but for some reason removing all permissions with
FileUtils.chmoddoesn't reproduce. Glob just returns an empty array instead.Not sure if the behaviour is platform specific, but rather than spending a disproportionate amount of effort writing this one test, I think it's safe to just rescue.