Add test items collection builder #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 11, 2025
vinistock
force-pushed
the
01-31-add_test_items_collection_builder
branch
from
dfcc5be to
b80e1d8
Compare
vinistock
changed the base branch from
graphite-base/3169
to
02-11-accept_module_class_node_s_constant_path_for_constant_name
This was referenced Feb 11, 2025
vinistock
force-pushed
the
02-11-accept_module_class_node_s_constant_path_for_constant_name
branch
from
c79c3e5 to
6dd76b8
Compare
vinistock
force-pushed
the
01-31-add_test_items_collection_builder
branch
from
b80e1d8 to
90ea02f
Compare
vinistock
changed the base branch from
02-11-accept_module_class_node_s_constant_path_for_constant_name
to
graphite-base/3169
vinistock
force-pushed
the
graphite-base/3169
branch
from
6dd76b8 to
f296ba4
Compare
vinistock
force-pushed
the
01-31-add_test_items_collection_builder
branch
from
90ea02f to
e9cbf36
Compare
vinistock
force-pushed
the
01-31-add_test_items_collection_builder
branch
3 times, most recently
from
675fbff to
aff14cb
Compare
andyw8
approved these changes
Feb 13, 2025
vinistock
force-pushed
the
01-31-add_test_items_collection_builder
branch
from
aff14cb to
3c2c02a
Compare
Merge activity
|
paracycle
reviewed
Feb 13, 2025
vinistock
commented
Feb 13, 2025
vinistock
force-pushed
the
01-31-add_test_items_collection_builder
branch
from
3c2c02a to
f5093ce
Compare
### Motivation To be able to provide complete test explorer support, we should create a collection builder with a corresponding interface object that allow us to provide VS Code with all of the information needed to provide full functionality for tests. This PR adds an initial version of a test item response builder that we can enhance as needed to represent test items. ### Implementation Created a test item object that matches what VS Code expects in the explorer. Also created a response builder to along with it. ### Automated Tests Added some tests.
graphite-app
bot
force-pushed
the
01-31-add_test_items_collection_builder
branch
from
f5093ce to
44a38fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To be able to provide complete test explorer support, we should create a collection builder with a corresponding interface object that allow us to provide VS Code with all of the information needed to provide full functionality for tests.
This PR adds an initial version of a test item response builder that we can enhance as needed to represent test items.
Implementation
Created a test item object that matches what VS Code expects in the explorer. Also created a response builder to along with it.
Automated Tests
Added some tests.