Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

[Storefront API Client] Reorganize tests for server and browser testing #1047

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

melissaluu
Copy link
Contributor

WHY are these changes introduced?

Reorganize the tests to clearly state tests specific for either server or browser environment.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md file manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@melissaluu melissaluu requested a review from a team as a code owner November 8, 2023 22:13
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Didn't really go into the tests because I'm assuming we're just moving things around, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I really like the concept of a fixtures file. Makes it much easier to find stuff!

@melissaluu
Copy link
Contributor Author

I'm assuming we're just moving things around, right?

Yup! I didn't add or remove anything - it's just reorganizing things...

@melissaluu melissaluu merged commit ba1e0bc into main Nov 9, 2023
10 checks passed
@melissaluu melissaluu deleted the ml-sfapi-client-segment-tests branch November 9, 2023 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants