Change create product route to POST /api/products
#128
Conversation
There was a problem hiding this comment.
We'll also need a separate PR to update the FE repo, right?
There was a problem hiding this comment.
Yeah I marked the frontend PR as ready for review just now because I thought it needed to be updated last, but the templates submodules are pointing to a specific commit, not main, so I believe we can merge in any order we want.
What I did in the template PRs is point to the frontend PR commit SHA, which should remain unchanged once it's merged to main as well.
There was a problem hiding this comment.
I missed the FE PR :)
Will running git submodule update --remote still pull the FE to the latest version if we point it at a specific commit, though?
There was a problem hiding this comment.
Oh yeah good call, I just checked and yeah it reverted to the latest commit on main, Shopify/shopify-frontend-template-react@87463db.
There was a problem hiding this comment.
Which I think makes sense, since the submodule points to main there - when we merge the PR we should be good :)
There was a problem hiding this comment.
Do you think it's best that I merge the FE PR first then update the BE templates to point to the merge commit or is this fine?
There was a problem hiding this comment.
Yeah I think that might be ideal!
rachel-carvalho
force-pushed
the
change_create_route_to_post
branch
from
484606f
to
f6823f0
Compare
WHY are these changes introduced?
We want to perform mutations with a POST instead of a GET.
WHAT is this pull request doing?
GET /api/products/createtoPOST /api/productsweb/frontendsubmodule to the commit which updatesfetchcall Change create product route toPOST /api/productsshopify-frontend-template-react#25918-51-gdfz2-ldfmc.mov
Checklist
Note: once this PR is merged, it becomes a new release for this template.
I have added/updated tests for this changeN/AI have made changes to theN/AREADME.mdfile and other related documentation, if applicable