Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template to use token exchange #129

Merged
merged 5 commits into from
May 3, 2024
Merged

Update template to use token exchange #129

merged 5 commits into from
May 3, 2024

Conversation

rachel-carvalho
Copy link
Contributor

@rachel-carvalho rachel-carvalho commented Apr 19, 2024 •
edited by zzooeeyy
Loading

WHY are these changes introduced?

We want to use the new embedded app auth strategy by default.

WHAT is this pull request doing?

  • Bump shopify_app version to v22.2.0
  • Enable new_embedded_auth_strategy in configuration
  • Use with_token_refetch in ProductCreator to perform token exchange when access token is invalid
  • Better error message displayed when encountering an API error
    • Old display: previous-error
    • New display: new-error

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

@zzooeeyy zzooeeyy force-pushed the update_template_for_token_exchange branch from 4bac55c to db7bd10 Compare May 2, 2024 21:34
@zzooeeyy zzooeeyy marked this pull request as ready for review May 2, 2024 21:35
@zzooeeyy zzooeeyy requested a review from a team as a code owner May 2, 2024 21:35
paulomarg
paulomarg approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how we were able to use the service as an example of with_refetch_token!

Also, much cleaner now! 🚀

@zzooeeyy zzooeeyy merged commit 13ac52f into main May 3, 2024
7 checks passed
@zzooeeyy zzooeeyy deleted the update_template_for_token_exchange branch May 3, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees

@rachel-carvalho rachel-carvalho

@zzooeeyy zzooeeyy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachel-carvalho @paulomarg @zzooeeyy