Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routes for declarative webhooks #141

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

lizkenyon
Copy link
Contributor

I had this change in this PR, but it got lost in a merge conflict.
This change is required to properly route webhook requests to the specific event routes

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
  • I have made changes to the README.md file and other related documentation, if applicable

Define specific webhook routes first

Otherwise the /webhooks route defined in shopify api will clobber the specific routes
@lizkenyon lizkenyon requested a review from a team as a code owner August 8, 2024 15:23
@lizkenyon lizkenyon merged commit b199c71 into main Aug 9, 2024
7 checks passed
@lizkenyon lizkenyon deleted the liz/update-routes branch August 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants