Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use GraphQL queries in the Ruby app template and remove Rest #152

Conversation

andy-liuu
Copy link
Contributor

@andy-liuu andy-liuu commented Nov 11, 2024

Test with this command

shopify app init --template=https://github.com/Shopify/shopify-app-template-ruby#andy-liuu/Use-GraphQL-queries-in-the-Ruby-app-template-and-remove-Rest       

WHY are these changes introduced?

Fixes https://github.com/Shopify/first-party-library-planning/issues/691

WHAT is this pull request doing?

  • Converting the rest api call to a graphql call
  • using the same style as the other gql call

Checklist

Note: once this PR is merged, it becomes a new release for this template.

  • I have added/updated tests for this change
    not applicable

  • I have made changes to the README.md file and other related documentation, if applicable
    not applicable

@andy-liuu andy-liuu self-assigned this Nov 11, 2024
@andy-liuu andy-liuu changed the title [Draft] Fix: Use GraphQL queries in the Ruby app template and remove Rest Fix: Use GraphQL queries in the Ruby app template and remove Rest Nov 11, 2024
@andy-liuu andy-liuu marked this pull request as ready for review November 11, 2024 15:09
@andy-liuu andy-liuu requested a review from a team as a code owner November 11, 2024 15:09
@andy-liuu andy-liuu merged commit 296f011 into main Nov 11, 2024
7 checks passed
@andy-liuu andy-liuu deleted the andy-liuu/Use-GraphQL-queries-in-the-Ruby-app-template-and-remove-Rest branch November 11, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants