Skip to content

Commit

Permalink
Disable outdated rules from eslint-plugin-react
Browse files Browse the repository at this point in the history
  • Loading branch information
xty committed Apr 23, 2023
1 parent 5ab0fcf commit 225e8c4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/wet-meals-retire.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/eslint-plugin': patch
---

Disable outdated rules (react/{react-in-jsx-scope,jsx-uses-react})
4 changes: 2 additions & 2 deletions packages/eslint-plugin/lib/config/react.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ module.exports = {
// Prevent missing props validation in a React component definition
'react/prop-types': 'error',
// Prevent missing React when using JSX
'react/react-in-jsx-scope': 'error',
'react/react-in-jsx-scope': 'off',
// Enforce a defaultProps definition for every prop that is not a required prop
'react/require-default-props': 'off',
// Enforce React components to have a shouldComponentUpdate method
Expand Down Expand Up @@ -193,7 +193,7 @@ module.exports = {
// Validate whitespace in and around the JSX opening and closing brackets
'react/jsx-tag-spacing': 'error',
// Prevent React to be incorrectly marked as unused
'react/jsx-uses-react': 'error',
'react/jsx-uses-react': 'off',
// Prevent variables used in JSX to be incorrectly marked as unused
'react/jsx-uses-vars': 'error',
// Prevent missing parentheses around multilines JSX
Expand Down

0 comments on commit 225e8c4

Please sign in to comment.