forked from mattermost/mattermost-redux
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove outdated information from contributing file (mattermost#824)
- Loading branch information
Showing
1 changed file
with
2 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,5 @@ | ||
| # Code Contribution Guidelines | ||
|
|
||
| Thank you for your interest in contributing! Please see the [Mattermost Contribution Guide](https://developers.mattermost.com/contribute/getting-started/) which describes the process for making code contributions across Mattermost projects and [join our "Contributors" community channel](https://pre-release.mattermost.com/core/channels/tickets) to ask questions from community members and the Mattermost core team. | ||
|
|
||
| ### Review Process for this Repo | ||
|
|
||
| After following the steps in the [Contribution Guide](http://docs.mattermost.com/developer/contribution-guide.html), submitted pull requests go through the review process outlined below. We aim to start reviewing pull requests in this repo the week they are submitted, but the length of time to complete the process will vary depending on the pull request. | ||
|
|
||
| The one exception may be around release time, where the review process may take longer as the team focuses on our [release process](https://docs.mattermost.com/process/release-process.html). | ||
|
|
||
| #### `Stage 1: PM Review` | ||
|
|
||
| A Product Manager will review the pull request to make sure it: | ||
|
|
||
| 1. Fits with our product roadmap | ||
| 2. Works as expected | ||
| 3. Meets UX guidelines | ||
|
|
||
| This step is sometimes skipped for bugs or small improvements with a ticket, but always happens for new features or pull requests without a related ticket. | ||
|
|
||
| The Product Manager may come back with some bugs or UI improvements to fix before the pull request moves on to the next stage. | ||
|
|
||
| #### `Stage 2: Dev Review` | ||
|
|
||
| Two developers will review the pull request and either give feedback or `+1` the PR. | ||
|
|
||
| Any comments will need to be addressed before the pull request moves on to the last stage. | ||
|
|
||
| - PRs that do not follow Style Guides cannot be merged | ||
|
|
||
| #### `Stage 3: Ready to Merge` | ||
|
|
||
| The review process is complete, and the pull request will be merged. | ||
| Thank you for your interest in contributing! Please see the [Mattermost Contribution Guide](https://developers.mattermost.com/contribute/getting-started/) which describes the process for making code contributions across Mattermost projects and [join our "Contributors" community channel](https://community.mattermost.com/core/channels/tickets) to ask questions from community members and the Mattermost core team. | ||
|
|
||
| When you submit a pull request, it goes through a [code review process outlined here](https://developers.mattermost.com/contribute/getting-started/code-review/). |