No implicit anys (mattermost#977)

* removed implicitany
Shragenator · Nov 12, 2019 · d4b6552 · d4b6552
1 parent 41e409d
commit d4b6552
Show file tree

Hide file tree

Showing 89 changed files with 1,203 additions and 727 deletions.
diff --git a/Makefile b/Makefile
@@ -23,7 +23,7 @@ clean: pre-run
 pre-run:
 	@echo Make sure no previous build are in the folder
 
-	@rm -rf build/* actions client constants reducers selectors store utils types mattermost.client4* index.* mattermost.websocket_client*
+	@rm -rf build/* action_types actions client constants reducers selectors store utils types mattermost.client4* index.* mattermost.websocket_client*
 
 test: check-style
 	npm test

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
     "redux-thunk": "2.3.0",
     "remote-redux-devtools": "0.5.16",
     "reselect": "4.0.0",
-    "serialize-error": "2.1.0",
+    "serialize-error": "5.0.0",
     "shallow-equals": "1.0.0"
   },
   "husky": {
@@ -56,6 +56,7 @@
     "@babel/preset-env": "7.6.0",
     "@babel/preset-typescript": "7.6.0",
     "@babel/runtime": "7.6.0",
+    "@types/shallow-equals": "1.0.0",
     "@typescript-eslint/eslint-plugin": "2.3.1",
     "@typescript-eslint/parser": "2.3.1",
     "@types/jest": "24.0.18",

diff --git a/src/actions/bots.ts b/src/actions/bots.ts
@@ -6,10 +6,11 @@ import {BotTypes} from 'action_types';
 import {bindClientFunc} from './helpers';
 
 import {ActionFunc} from 'types/actions';
+import {Bot, BotPatch} from 'types/bots';
 
 const BOTS_PER_PAGE_DEFAULT = 20;
 
-export function createBot(bot): ActionFunc {
+export function createBot(bot: Bot): ActionFunc {
     return bindClientFunc({
         clientFunc: Client4.createBot,
         onSuccess: BotTypes.RECEIVED_BOT_ACCOUNT,
@@ -19,7 +20,7 @@ export function createBot(bot): ActionFunc {
     });
 }
 
-export function patchBot(botUserId, botPatch): ActionFunc {
+export function patchBot(botUserId: string, botPatch: BotPatch): ActionFunc {
     return bindClientFunc({
         clientFunc: Client4.patchBot,
         onSuccess: BotTypes.RECEIVED_BOT_ACCOUNT,
@@ -30,7 +31,7 @@ export function patchBot(botUserId, botPatch): ActionFunc {
     });
 }
 
-export function loadBot(botUserId): ActionFunc {
+export function loadBot(botUserId: string): ActionFunc {
     return bindClientFunc({
         clientFunc: Client4.getBot,
         onSuccess: BotTypes.RECEIVED_BOT_ACCOUNT,
@@ -51,7 +52,7 @@ export function loadBots(page = 0, perPage = BOTS_PER_PAGE_DEFAULT): ActionFunc
     });
 }
 
-export function disableBot(botUserId): ActionFunc {
+export function disableBot(botUserId: string): ActionFunc {
     return bindClientFunc({
         clientFunc: Client4.disableBot,
         onSuccess: BotTypes.RECEIVED_BOT_ACCOUNT,
@@ -61,7 +62,7 @@ export function disableBot(botUserId): ActionFunc {
     });
 }
 
-export function enableBot(botUserId): ActionFunc {
+export function enableBot(botUserId: string): ActionFunc {
     return bindClientFunc({
         clientFunc: Client4.enableBot,
         onSuccess: BotTypes.RECEIVED_BOT_ACCOUNT,
@@ -71,7 +72,7 @@ export function enableBot(botUserId): ActionFunc {
     });
 }
 
-export function assignBot(botUserId, newOwnerId): ActionFunc {
+export function assignBot(botUserId: string, newOwnerId: string): ActionFunc {
     return bindClientFunc({
         clientFunc: Client4.assignBot,
         onSuccess: BotTypes.RECEIVED_BOT_ACCOUNT,

diff --git a/src/actions/channels.ts b/src/actions/channels.ts
@@ -573,7 +573,7 @@ export function getMyChannelMembers(teamId: string): ActionFunc {
 
 export function getChannelMembers(channelId: string, page = 0, perPage: number = General.CHANNELS_CHUNK_SIZE): ActionFunc {
     return async (dispatch: DispatchFunc, getState: GetStateFunc) => {
-        let channelMembers;
+        let channelMembers: ChannelMembership[];
 
         try {
             const channelMembersRequest = Client4.getChannelMembers(channelId, page, perPage);

diff --git a/src/actions/errors.ts b/src/actions/errors.ts
@@ -1,7 +1,7 @@
 // Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
 // See LICENSE.txt for license information.
 import {ErrorTypes} from 'action_types';
-import serializeError from 'serialize-error';
+import {serializeError, ErrorObject} from 'serialize-error';
 import {Client4} from 'client';
 import EventEmitter from 'utils/event_emitter';
 import {DispatchFunc, ActionFunc} from 'types/actions';
@@ -22,7 +22,7 @@ export function dismissError(index: number): ActionFunc {
     };
 }
 
-export function getLogErrorAction(error: serializeError.ErrorObject, displayable = false) {
+export function getLogErrorAction(error: ErrorObject, displayable = false) {
     return {
         type: ErrorTypes.LOG_ERROR,
         displayable,

diff --git a/src/actions/files.ts b/src/actions/files.ts
@@ -7,6 +7,7 @@ import {Action, batchActions, DispatchFunc, GetStateFunc, ActionFunc} from 'type
 
 import {logError} from './errors';
 import {bindClientFunc, forceLogoutIfNecessary} from './helpers';
+import {FileUploadResponse} from 'types/files';
 
 export function getFilesForPost(postId: string): ActionFunc {
     return async (dispatch: DispatchFunc, getState: GetStateFunc) => {
@@ -34,7 +35,7 @@ export function uploadFile(channelId: string, rootId: string, clientIds: Array<s
     return async (dispatch: DispatchFunc, getState: GetStateFunc) => {
         dispatch({type: FileTypes.UPLOAD_FILES_REQUEST, data: {}}, getState);
 
-        let files;
+        let files: FileUploadResponse;
         try {
             files = await Client4.uploadFile(fileFormData, formBoundary);
         } catch (error) {