Skip to content

Commit

Permalink
Update PR template for TypeScript and added makefile command (matterm…
Browse files Browse the repository at this point in the history
  • Loading branch information
devinbinnie authored and jespino committed Jan 23, 2020
1 parent af7a071 commit d8a0e29
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ pre-run:
test: check-style
npm test

check-types: | pre-run node_modules
npm run tsc

install: node_modules

Expand Down
2 changes: 1 addition & 1 deletion PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
REMEMBER TO:
- Run `make check-style` to check for style errors (required for all pull requests)
- Run `make test` to ensure unit tests passed
- Run `make flow` to ensure type checking passed
- Run `make check-types` to ensure type checking passed
- Add or update unit tests (required for all new features)
- All new/modified APIs include changes to the [JavaScript driver](https://github.com/mattermost/mattermost-redux/blob/master/src/client/client4.js)
-->
Expand Down

0 comments on commit d8a0e29

Please sign in to comment.