WIP: Add a dedicated external trigger scan #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschall
added
enhancement
cbespin
requested changes
Feb 23, 2024
There was a problem hiding this comment.
Nice work! I just think we should keep the scan_timeout stopping criterium for the external trigger scan, similar to all other projects. I do not have a specific use case i mind but it is easier to deactivate it rather than patch something together if needed.
cbespin
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dedicated external trigger scan (
scan_ext_trigger) for measurements utilizing a TLU. Additionally, the oldscan_simple.pyis changed toscan_source.pyand will not support TLU based measurements further.This way we want to separate between source measurements and beam test measurements with a TLU setup to avoid confusion in the scan naming and calling.