ππͺ β£ [STA-13 HDASH-5] Attempting to fix inheritance issues with layouts #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the magic frontend, the tags run through the component. This allows us to automate the magic signin useStates/useEffects & have the header menu included, but it leads to issues with custom pages (say from other formats/templates like this main dashboard) (see image below):
I don't think this will format correctly on mobile devices (and it looks sort of odd on desktop views. Maybe we can add a custom header format and remove the margins between the menu divider and the header, include deeplinking to other parts of the app)
The main issue is that currently we don't seem to be able to add multiple layouts with react-router-domβ¦
Here's my attempt to create a new layout:
src/components/db-layout.js
App.jsx
has the Route configuration for different pages: