BUG: Enable/disable the Segmentation tab when "Select All Series"/"De… #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…select All Series" buttons are clicked. Fixes issue SlicerProstate#111.
|
That would only fix a part of #110 The user could still deselect all series manually and the segmentation tab would still be enabled. |
|
Whoops, yeah, you're right on both counts. I had (incorrectly) assumed that I introduced the bug. I'll submit a separate pull request when I actually get it fixed. |
|
@fedorov I didn't see your reply. Sorry for the spam |
|
:) no worries, thanks! |
fedorov
added a commit
that referenced
this pull request
Mar 1, 2016
BUG: Enable/disable the Segmentation tab when "Select All Series"/"De…
|
@brikeats another suggestion, it would be nice to use this kind of "select/deselect all" control:
instead of the buttons at the bottom of the list
|
|
I agree. Usually that series selection widget should not become that large, but there are some issues regarding the QTabWidget which always resizes all tabs to the biggest width/height. I am going to find out how we can fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…select All Series" buttons are clicked. Fixes issue #111.