Merge pull request #61 from Slivo-fr/release/v2.2.4

Release/v2.2.4
Slivo-fr · Sep 12, 2022 · 07cc545 · 07cc545
2 parents 2a3cc18 + ff0d180
commit 07cc545
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/TranqRotate.toc b/TranqRotate.toc
@@ -1,8 +1,8 @@
-## Interface: 11401
-## Title: TranqRotate |cff00aa002.2.3|r
+## Interface: 11403
+## Title: TranqRotate |cff00aa002.2.4|r
 ## Notes: A tranqshot rotation assistant
 ## Author: Slivo
-## Version: 2.2.3
+## Version: 2.2.4
 ## SavedVariables: TranqRotateDb
 ## OptionalDeps: Ace3
 

diff --git a/TranqRotate_TBC.toc b/TranqRotate_TBC.toc
@@ -1,8 +1,8 @@
-## Interface: 20502
-## Title: TranqRotate |cff00aa002.2.3|r
+## Interface: 20504
+## Title: TranqRotate |cff00aa002.2.4|r
 ## Notes: A tranqshot rotation assistant
 ## Author: Slivo
-## Version: 2.2.3
+## Version: 2.2.4
 ## SavedVariables: TranqRotateDb
 ## OptionalDeps: Ace3
 

diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,10 @@
 ## TranqRotate Changelog
 
+#### v2.2.4
+
+- Minor fix regarding version checks
+- Bump toc for 1.14.3 & 2.5.4
+
 #### v2.2.3
 
 - Incapacitated backup alert should now work properly

diff --git a/src/tranqRotate.lua b/src/tranqRotate.lua
@@ -313,16 +313,18 @@ end
 -- @return major, minor, fix, isStable
 function TranqRotate:parseVersionString(versionString)
 
-    local version, type = strsplit("-", versionString)
+    local version, versionType = strsplit("-", versionString)
     local major, minor, fix = strsplit( ".", version)
 
-    return tonumber(major), tonumber(minor), tonumber(fix), type == nil
+    return tonumber(major), tonumber(minor), tonumber(fix), versionType == nil
 end
 
 -- Check if the given version would require updating
 -- @return requireUpdate, breakingUpdate
 function TranqRotate:isUpdateRequired(versionString)
 
+    if (nil == versionString) then return false, false end
+
     local remoteMajor, remoteMinor, remoteFix, isRemoteStable = self:parseVersionString(versionString)
     local localMajor, localMinor, localFix, isLocalStable = self:parseVersionString(TranqRotate.version)