Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v2.2.4 #61

Merged
merged 3 commits into from
Sep 12, 2022
+15 −8
Merged

Release/v2.2.4 #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6cb944
Minor update check improvements
Slivo-fr Apr 27, 2022
cd30fee
Update ERA and last TBC toc
Slivo-fr Sep 9, 2022
ff0d180
Update readme
Slivo-fr Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions TranqRotate.toc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
## Interface: 11401
## Title: TranqRotate |cff00aa002.2.3|r
## Interface: 11403
## Title: TranqRotate |cff00aa002.2.4|r
## Notes: A tranqshot rotation assistant
## Author: Slivo
## Version: 2.2.3
## Version: 2.2.4
## SavedVariables: TranqRotateDb
## OptionalDeps: Ace3

Expand Down
6 changes: 3 additions & 3 deletions TranqRotate_TBC.toc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
## Interface: 20502
## Title: TranqRotate |cff00aa002.2.3|r
## Interface: 20504
## Title: TranqRotate |cff00aa002.2.4|r
## Notes: A tranqshot rotation assistant
## Author: Slivo
## Version: 2.2.3
## Version: 2.2.4
## SavedVariables: TranqRotateDb
## OptionalDeps: Ace3

Expand Down
5 changes: 5 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
## TranqRotate Changelog

#### v2.2.4

- Minor fix regarding version checks
- Bump toc for 1.14.3 & 2.5.4

#### v2.2.3

- Incapacitated backup alert should now work properly
Expand Down
6 changes: 4 additions & 2 deletions src/tranqRotate.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,16 +313,18 @@ end
-- @return major, minor, fix, isStable
function TranqRotate:parseVersionString(versionString)

local version, type = strsplit("-", versionString)
local version, versionType = strsplit("-", versionString)
local major, minor, fix = strsplit( ".", version)

return tonumber(major), tonumber(minor), tonumber(fix), type == nil
return tonumber(major), tonumber(minor), tonumber(fix), versionType == nil
end

-- Check if the given version would require updating
-- @return requireUpdate, breakingUpdate
function TranqRotate:isUpdateRequired(versionString)

if (nil == versionString) then return false, false end

local remoteMajor, remoteMinor, remoteFix, isRemoteStable = self:parseVersionString(versionString)
local localMajor, localMinor, localFix, isLocalStable = self:parseVersionString(TranqRotate.version)

Expand Down