Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add lib to xmake-repo #3

Open
shevernitskiy opened this issue Sep 24, 2023 · 5 comments
Open

feature request: add lib to xmake-repo #3

shevernitskiy opened this issue Sep 24, 2023 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@shevernitskiy
Copy link

shevernitskiy commented Sep 24, 2023

Hey! Thanks for a great hooking lib. You did exaclty what everybody thinking about!:)
I suggest to add lib to xmake-repo. It will be very helpful for xmake users:)
https://github.com/xmake-io/xmake-repo

@ElCapor
Copy link

ElCapor commented Apr 15, 2024

I will give a try at adding it to xmake repo , even though i aint expert , i assume you'd just use the cmake backend in xmake

@Smertig
Copy link
Owner

Smertig commented May 6, 2024

Hey, @shevernitskiy. Thanks for your kind words! Apologize for the late response, I had a break from C++.

I did a few attempts on adding rcmp to the xmake-repo, but it seems there's no simple and direct way to write correct xmake.lua even in case of small CMake-based project that can be added as a subdirectory otherwise. Any help is highly appreciated, I'm leaving this issue as opened.

@Smertig Smertig added the help wanted Extra attention is needed label May 6, 2024
@waruqi
Copy link

waruqi commented May 6, 2024

xmake-io/xmake-repo#3964

@Smertig
Copy link
Owner

Smertig commented May 8, 2024

@waruqi, thank you for your help! As I see from your PR to xmake-repo, you wrote some duplicated code, i.e. specified /include directory directly and added some defines for library version. I'm wondering if it's really needed? Can I somehow modify rcmp or CMakeLists.txt so xmake "recipe" becomes simpler?

@waruqi
Copy link

waruqi commented May 9, 2024

specified /include directory directly and added some defines for library version

  1. provide cmake install configuration to install headers/libs in CMakeLists.txt
  2. support static/shared for BUILD_SHARED_LIBS
  3. generate config.h file to save RCMP_VERSION_MAJOR/RCMP_VERSION_MINOR/RCMP_VERSION_PATCH or define them in rcmp code, otherwise when the user uses the library header files, they are undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants