add rcmp #3964
Merged
add rcmp #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这种连 cmake install 都没有的小库，直接 port 了更快= = |
|
反正它的 cmakelists 能用，就凑合着用，有上游维护 总比这边维护来的好，省得版本更新后，不同步，还得分版本维护。。 |
|
可以 patch cmake 把依赖拆了 #3965 |
这个等过了 再来个 pr 吧 |
Anyway, its cmakelists can be used, so just use it. It is better to have upstream maintenance than to maintain it here. It avoids the need for version maintenance after the version is updated and is out of sync. . |
I've waited for this. Let's do another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smertig/rcmp#3