Don't restrict modifiers to GBM_MAX_PLANES
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modifiers argument doesn't seem to be modifiers for each plane. Rather, it's a set of modifiers that the driver will choose a preference out of. So it doesn't make sense to limit this.
ids1024
added a commit
to pop-os/xdg-desktop-portal-cosmic
that referenced
this pull request
Feb 5, 2024
This is similar to what `xdg-desktop-portal-wlr` does. This depends on Smithay/gbm.rs#34 to be able to use any of the modifiers.
Drakulix
approved these changes
Feb 6, 2024
ids1024
added a commit
to pop-os/xdg-desktop-portal-cosmic
that referenced
this pull request
Feb 7, 2024
This is similar to what `xdg-desktop-portal-wlr` does. This depends on Smithay/gbm.rs#34 to be able to use any of the modifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modifiers argument doesn't seem to be modifiers for each plane. Rather, it's a set of modifiers that the driver will choose a preference out of. So it doesn't make sense to limit this.