Fix crash in replicationCacheMaster() expecting a nullptr cached_master #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replicationCacheMaster() function expects the master pointer to be non-nullptr and the cached_master to be nullptr. But if we happened to get disconnected multiple times and thus also go multiple times through replicationCreateMasterClient(), then we end up with both master and cached_master being non-nullptr, which then triggers an assertion in replicationCacheMaster() which crashes the server. When we are recreating the master struct, mark cached_master for asynchronous freeing, and reset its pointer. Fixes: Snapchat#849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replicationCacheMaster() function expects the master pointer to be non-nullptr and the cached_master to be nullptr. But if we happened to get disconnected multiple times and thus also go multiple times through replicationCreateMasterClient(), then we end up with both master and cached_master being non-nullptr, which then triggers an assertion in replicationCacheMaster() which crashes the server.
When we are recreating the master struct, mark cached_master for asynchronous freeing, and reset its pointer.
Fixes: #849
This fixes this crash for us, but then we get after a bit another apparently unrelated crash, although that might be due to the database being damaged (which was the trigger in our case) or something else. But given the amount of crash reports filed, this does not seem surprising.