Skip to content

Commit

Permalink
Alchemist Checks, Dalaran Mage Buffs, Bug Fixes
Browse files Browse the repository at this point in the history
Added the new dalaran buffs for mages, pots etc are adjusted for alchemists and fixed various bugs.
  • Loading branch information
Softrix committed Oct 22, 2022
1 parent eb3596d commit 39dc6e0
Show file tree
Hide file tree
Showing 14 changed files with 121 additions and 96 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
*.wowproj
*.wowsln
.vs/SmartBuff/v17/.wowsuo
work-in-progress.txt
*.log
2 changes: 1 addition & 1 deletion SmartBuff-Classic.toc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Interface: 11403
## Title: |TInterface\Addons\Smartbuff\Icons\IconEnabled:0|t SmartBuff |cffffffff(Classic Version)|r
## Version: 37.11403
## Version: 38.11403
## Author: |cff20d2ffCodermik (Mik / Castanova on EU-Mirage Raceway) & Aeldra|r (EU-Proudmoore)
## Notes: Cast the most important buffs on you or party, raid, pets and assigned tanks. Use /sbm for options menu.
## DefaultState: Enabled
Expand Down
2 changes: 1 addition & 1 deletion SmartBuff-TBC.toc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Interface: 20504
## Title: |TInterface\Addons\Smartbuff\Icons\IconEnabled:0|t SmartBuff |cffffffff(TBC Classic)|r
## Version: 37.20504
## Version: 38.20504
## Author: |cff20d2ffCodermik (Mik / Castanova on EU-Mirage Raceway) & Aeldra|r (EU-Proudmoore)
## Notes: Cast the most important buffs on you or party, raid, pets and assigned tanks. Use /sbm for options menu.
## DefaultState: Enabled
Expand Down
148 changes: 80 additions & 68 deletions SmartBuff.buffs.lua

Large diffs are not rendered by default.

19 changes: 10 additions & 9 deletions SmartBuff.lua
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
-- Cast the most important buffs on you, tanks or party/raid members/pets.
-------------------------------------------------------------------------------

SMARTBUFF_DATE = "171022";
SMARTBUFF_VERSION = "r37."..SMARTBUFF_DATE;
SMARTBUFF_DATE = "221022 Dev";
SMARTBUFF_VERSION = "r38."..SMARTBUFF_DATE;
SMARTBUFF_VERSIONMIN = 11403; -- min version
SMARTBUFF_VERSIONNR = 30400; -- max version
SMARTBUFF_TITLE = "SmartBuff";
Expand Down Expand Up @@ -1220,16 +1220,18 @@ function SMARTBUFF_SetBuff(buff, i, ia)
cBuffs[i].IconS = texture;

else
local _, _, _, _, minLevel = GetItemInfo(cBuffs[i].BuffS);
local itemsName, _, _, _, minLevel = GetItemInfo(cBuffs[i].BuffS);
if (not IsMinLevel(minLevel)) then
cBuffs[i] = nil;
return i;
end

local _, _, count, texture = SMARTBUFF_FindItem(cBuffs[i].BuffS, cBuffs[i].Chain);
if (count <= 0) then
if (count <= 0) then
cBuffs[i] = nil;
return i;
else
-- print("Found: "..cBuffs[i].BuffS..", count: "..count)
end
cBuffs[i].IconS = texture;
end
Expand Down Expand Up @@ -3132,13 +3134,12 @@ function SMARTBUFF_FindItem(reagent, chain)
--itemName = string.match(itemLink, "item[%-?%d:]+");
--itemName = string.match(itemLink, "|h%[.*%]|h");
itemName = string.match(itemLink, "%[.-%]");
--print(bag, slot, itemName);
-- print(bag, slot, itemName);
--SMARTBUFF_AddMsgD("Reagent found: " .. itemLink);
for i = 1, #chain, 1 do
--print(chain[i]);
if (chain[i] and string.find(itemName, chain[i], 1, true)) then
--if (chain[i] and string.find(itemLink, "["..chain[i].."]", 1, true)) then
--print("Item found: "..chain[i]);
--if (chain[i] and string.find(itemName, chain[i], 1, true)) then
if (chain[i] and string.find(itemLink, "["..chain[i].."]", 1, true)) then
-- print("Item found: "..chain[i]);
texture, count = GetContainerItemInfo(bag, slot);
return bag, slot, count, texture;
end
Expand Down
2 changes: 1 addition & 1 deletion SmartBuff.toc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Interface: 30400
## Title: |TInterface\Addons\Smartbuff\Icons\IconEnabled:0|t SmartBuff |cffffffff(WOTLK Classic)|r
## Version: 37.30400
## Version: 38.30400
## Author: |cff20d2ffCodermik (Mik / Castanova on EU-Mirage Raceway) & Aeldra|r (EU-Proudmoore)
## Notes: Cast the most important buffs on you or party, raid, pets and assigned tanks. Use /sbm for options menu.
## DefaultState: Enabled
Expand Down
9 changes: 0 additions & 9 deletions known-issues.txt
Original file line number Diff line number Diff line change
@@ -1,9 +0,0 @@


WOTLK Beta Issues:

As of 19/07/2022, Theres a known issue on API call IsSpellInRange where it is always returning nil as if the wrong
parameters have been provided - it should be returning 1 if a player is in range and 0 if he/she is out of range.

Try: IsSpellInRange("Arcane Brilliance", "player") on a mage.

3 changes: 3 additions & 0 deletions localization.cn.lua
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ SMARTBUFF_CREDITS = "|cffffffff"
.."|cffffffffPayPal.Me: |cff00e0ffhttps://paypal.me/codermik\n\n"
;

-- Alchemy
SMARTBUFF_ALCHEMY_TITLE = "炼金术";

-- 德鲁伊
SMARTBUFF_DRUID_CAT = "猎豹形态";
SMARTBUFF_DRUID_MOONKIN = "枭兽形态";
Expand Down
3 changes: 3 additions & 0 deletions localization.de.lua
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ SMARTBUFF_CREDITS = "|cffffffff"
.."|cffffffffPayPal.Me: |cff00e0ffhttps://paypal.me/codermik\n\n"
;

-- Alchemy
SMARTBUFF_ALCHEMY_TITLE = "Alchemie";

-- Weapon types
SMARTBUFF_WEAPON_STANDARD = {"Dolche", "äxte", "schwerter", "streitkolben", "Stäbe", "Faustwaffen", "Stangenwaffen", "Wurfwaffe"};
SMARTBUFF_WEAPON_BLUNT = {"streitkolben", "Faustwaffen", "Stäbe"};
Expand Down
15 changes: 8 additions & 7 deletions localization.en.lua
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@
SMARTBUFF_WHATSNEW = "\n\n|cffffffff Whats new:|r\n\n"
.." |cffffffffClassic version by Codermik\n"
.." Please report any issues on Curse or Discord.|r\n\n\n"
.." Changes in r37:\n\n"
.." * Fixed a battleground cross-realm issue thats \n"
.." causing some system messages when the addon\n"
.." tries to send version information.\n\n"
.." * Added Flask of the North for Alchemists. \n\n"
.." * Added missing scrolls (thanks Emmalee via \n"
.." my Discord). \n\n"
.." Changes in r38:\n\n"
.." * Addon now checks for Alchemy and adjusts the \n"
.." duration of pots, elixir's etc.\n\n"
.." * Added Dalaran Mage buffs. \n\n"
.." * Various other bug fixes. \n\n"
.."\n\n"
.." |c0000FF96Many thanks to Chris S. for his donation and\n"
.." supporting my addon development.\n\n"
Expand All @@ -39,6 +37,9 @@ SMARTBUFF_CREDITS = "|cffffffff"
.."|cffffffffPayPal.Me: |cff00e0ffhttps://paypal.me/codermik\n\n"
;

-- Alchemy
SMARTBUFF_ALCHEMY_TITLE = "Alchemy";

-- Weapon types
SMARTBUFF_WEAPON_STANDARD = {"Daggers", "Axes", "Swords", "Maces", "Staves", "Fist Weapons", "Polearms", "Thrown"};
SMARTBUFF_WEAPON_BLUNT = {"Maces", "Staves", "Fist Weapons"};
Expand Down
3 changes: 3 additions & 0 deletions localization.es.lua
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ SMARTBUFF_CREDITS = "|cffffffff"
.."|cffffffffPayPal.Me: |cff00e0ffhttps://paypal.me/codermik\n\n"
;

-- Alchemy
SMARTBUFF_ALCHEMY_TITLE = "Alquimia";

-- Weapon types
SMARTBUFF_WEAPON_STANDARD = {"Dagas", "Hachas", "Espadas", "Mazas", "Bastones", "Armas de pu\195\177o", "Lanzas", "Arma arrojadiza"};
SMARTBUFF_WEAPON_BLUNT = {"Mazas", "Bastones", "Armas de pu\195\177o"};
Expand Down
3 changes: 3 additions & 0 deletions localization.fr.lua
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ SMARTBUFF_CREDITS = "|cffffffff"
.."|cffffffffPayPal.Me: |cff00e0ffhttps://paypal.me/codermik\n\n"
;

-- Alchemy
SMARTBUFF_ALCHEMY_TITLE = "Alchimie";

-- Weapon types
SMARTBUFF_WEAPON_STANDARD = {"Dagues", "Haches", "Ep\195\169es", "Masses", "B\195\162tons", "Armes de pugilat", "Armes d\'hast", "Armes de jet"};
SMARTBUFF_WEAPON_BLUNT = {"Masses", "B\195\162tons", "Armes de pugilat"};
Expand Down
3 changes: 3 additions & 0 deletions localization.ru.lua
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ SMARTBUFF_CREDITS = "|cffffffff"
.."|cffffffffPayPal.Me: |cff00e0ffhttps://paypal.me/codermik\n\n"
;

-- Alchemy
SMARTBUFF_ALCHEMY_TITLE = "Алхимия";

-- Weapon types
SMARTBUFF_WEAPON_STANDARD = {"Кинжалы", "топоры", "мечи", "дробящее", "Посохи", "Кистевое", "Древковое", "Метательное"};
SMARTBUFF_WEAPON_BLUNT = {"дробящее", "Посохи", "Кистевое"};
Expand Down
3 changes: 3 additions & 0 deletions localization.tw.lua
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ SMARTBUFF_CREDITS = "|cffffffff"
.."|cffffffffPayPal.Me: |cff00e0ffhttps://paypal.me/codermik\n\n"
;

-- Alchemy
SMARTBUFF_ALCHEMY_TITLE = "鍊金術";

-- Weapon types
SMARTBUFF_WEAPON_STANDARD = {"匕首", "", "", "", "法杖", "拳套", "長柄武器", "投擲武器"};
SMARTBUFF_WEAPON_BLUNT = {"", "法杖", "拳套"};
Expand Down

0 comments on commit 39dc6e0

Please sign in to comment.