Skip to content

Commit

Permalink
Bug fixes (r54 Release)
Browse files Browse the repository at this point in the history
Fixed no buffing while moving under classic era and hc, well fed (thanks emmalee) and a few others.
  • Loading branch information
Softrix committed Oct 14, 2023
1 parent 2aadbfa commit 8f36745
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 21 deletions.
2 changes: 1 addition & 1 deletion SmartBuff.buffs.lua
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ function SMARTBUFF_InitSpellIDs()
SMARTBUFF_WarStomp = GetSpellInfo(20549); --"War Stomp"

-- Food
SMARTBUFF_FOOD_AURA = GetSpellInfo(46899); --"Well Fed"
SMARTBUFF_FOOD_AURA = GetSpellInfo(19705); --"Well Fed"
SMARTBUFF_FOOD_SPELL = GetSpellInfo(433); --"Food"
SMARTBUFF_DRINK_SPELL = GetSpellInfo(430); --"Drink"

Expand Down
15 changes: 7 additions & 8 deletions SmartBuff.lua
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
-- Cast the most important buffs on you, tanks or party/raid members/pets.
-------------------------------------------------------------------------------

SMARTBUFF_DATE = "111023";
SMARTBUFF_DATE = "141023";

SMARTBUFF_VERSION = "r53."..SMARTBUFF_DATE;
SMARTBUFF_VERSION = "r54."..SMARTBUFF_DATE;
SMARTBUFF_VERSIONNR = 30403;
SMARTBUFF_VERWOTLK = false;
SMARTBUFF_TITLE = "SmartBuff";
Expand All @@ -26,7 +26,7 @@ local SmartbuffCommands = { "SBCVER", "SBCCMD", "SBCSYC" }
local SmartbuffSession = true;
local SmartbuffVerCheck = false; -- for my use when checking guild users/testers versions :)
local buildInfo = select(4, GetBuildInfo())
local SmartbuffRevision = 53;
local SmartbuffRevision = 54;
local SmartbuffVerNotifyList = {}

-- Using LibRangeCheck-2.0 by Mitchnull
Expand Down Expand Up @@ -136,7 +136,7 @@ local currentSpell = nil;
local currentTemplate = nil;
local currentSpec = nil;

local imgSB = "Interface\\Icons\\Spell_Nature_Purge";
local imgSB = "Interface\\Icons\\WoW_Token01";
local imgIconOn = "Interface\\AddOns\\SmartBuff\\Icons\\MiniMapButtonEnabled";
local imgIconOff = "Interface\\AddOns\\SmartBuff\\Icons\\MiniMapButtonDisabled";

Expand Down Expand Up @@ -1276,6 +1276,7 @@ function SMARTBUFF_SetBuff(buff, i, ia)
cBuffs[i] = nil;
return i;
end

elseif (ia or cBuffs[i].Type == SMARTBUFF_CONST_ITEMGROUP) then
local _, _, _, _, minLevel, _, _, _, _, texture = GetItemInfo(cBuffs[i].BuffS);
if (not IsMinLevel(minLevel)) then
Expand Down Expand Up @@ -1967,8 +1968,6 @@ function SMARTBUFF_BuffUnit(unit, subgroup, mode, spell)
bUsable = false;
end
else
-- classic era / hardcore mana gems & food check, a little dirty but it works for now,
-- i'll come back to this later and tidy it up :)
if not isPlayerMoving then
local lookupData
if (buffnS == SMARTBUFF_CONJFOOD) then
Expand All @@ -1992,7 +1991,7 @@ function SMARTBUFF_BuffUnit(unit, subgroup, mode, spell)
(buffnS == SMARTBUFF_CREATEMGEM_RUBY and SMARTBUFF_CheckBagItem(SMARTBUFF_MANARUBY)) then
bUsable = false;
end
else
elseif (buffnS == SMARTBUFF_CONJFOOD or buffnS == SMARTBUFF_CONJWATER) and isPlayerMoving then
bUsable = false;
end
end
Expand Down Expand Up @@ -3194,7 +3193,7 @@ function SMARTBUFF_Options_Init(self)
if (O.RebuffTimer == nil) then O.RebuffTimer = 20; end
if (O.SplashDuration == nil) then O.SplashDuration = 2; end
if (O.SplashIconSize == nil) then O.SplashIconSize = 16; end
if (O.BuffTarget == nil) then O.BuffTarget = true; end
if (O.BuffTarget == nil) then O.BuffTarget = false; end
if (O.BuffPvP == nil) then O.BuffPvP = false; end
if (O.BuffInCities == nil) then O.BuffInCities = true; end
if (O.LinkSelfBuffCheck == nil) then O.LinkSelfBuffCheck = true; end
Expand Down
2 changes: 1 addition & 1 deletion SmartBuff.toc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Interface: 30403
## Title: |TInterface\Addons\Smartbuff\Icons\IconEnabled:0|t SmartBuff |cffffffff(WOTLK)|r
## Version: 53.30403
## Version: 54.30403
## Author: |cff20d2ffCodermik & Aeldra|r (EU-Proudmoore)
## Contributing Author: |cff20d2ffSpeedwaystar
## Notes: Automatically cast buffs on yourself, your party or raid members and their pets. Use /sbm for the options menu.
Expand Down
2 changes: 1 addition & 1 deletion SmartBuff.xml
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@
SMARTBUFF_SetButtonPos(self);
</OnDragStop>
</Scripts>
<NormalTexture file="Interface\Icons\Spell_Nature_Purge" />
<NormalTexture file="Interface\ICONS\WoW_Token01" />
</Button>
<Frame name="SmartBuffOptionsFrame" hidden="true" parent="UIParent" toplevel="true" movable="true" frameStrata="DIALOG" enableMouse="true">
<Size>
Expand Down
18 changes: 8 additions & 10 deletions localization.en.lua
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,14 @@
SMARTBUFF_WHATSNEW = "\n\n"
.." |cff00e0ffClassic & Retail versions by Codermik with additional\n"
.." retail coding by Speedwaystar.\n\n"
.." |cffffffffChanges in r53.111023 (Classic):\n\n"
.." * Classic Era, Hardcore and WOTLK now share \n"
.." the same codebase, this will make my life\n"
.." so much easier moving forward :)\n\n"
.." * WOTLK TOC Updated to 30403 \n\n"
.." * Sounds are now local, this allows me to provide \n"
.." retail or custom sounds for splash prompts.\n\n"
.." * Under classic era and hardcore Mage Mana Gems \n"
.." are separated and can now all be created.\n\n"
.." * Added some missing sounds originally in ERA. \n\n"
.." |cffffffffChanges in r54.141023 (Classic):\n\n"
.." * Fixed Well Fed SpellId - Thanks EmmaLee \n\n"
.." * Reverted back 'Buff Target' setting to off.\n\n"
.." * Changed the default action button graphic\n"
.." that shows when no action is needed to a\n"
.." World of Warcraft logo.\n\n"
.." * Fixed bug under Classic ERA preventing buffs \n"
.." when running with your character. \n"
.."\n\n"
.." |cffffff00I currently play on the Mirage Raceway EU classic\n"
.." WOTLK server as Alliance, I play on Mik, Gabella,\n"
Expand Down

0 comments on commit 8f36745

Please sign in to comment.