Skip to content

Commit

Permalink
Fixed target buffing / Adjusted frame size
Browse files Browse the repository at this point in the history
Fixed target buffing, needs further testing.
  • Loading branch information
Softrix committed May 21, 2023
1 parent 894d3ec commit b0e199e
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 29 deletions.
10 changes: 5 additions & 5 deletions SmartBuff.lua
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

SMARTBUFF_DATE = "210523";

SMARTBUFF_VERSION = "r42."..SMARTBUFF_DATE;
SMARTBUFF_VERSION = "r43."..SMARTBUFF_DATE;
SMARTBUFF_VERSIONNR = 30401;
SMARTBUFF_TITLE = "SmartBuff";
SMARTBUFF_SUBTITLE = "Supports you in casting buffs";
Expand All @@ -25,7 +25,7 @@ local SmartbuffCommands = { "SBCVER", "SBCCMD", "SBCSYC" }
local SmartbuffSession = true;
local SmartbuffVerCheck = false; -- for my use when checking guild users/testers versions :)
local buildInfo = select(4, GetBuildInfo())
local SmartbuffRevision = 42;
local SmartbuffRevision = 43;
local SmartbuffVerNotifyList = {}

-- Using LibRangeCheck-2.0 by Mitchnull
Expand Down Expand Up @@ -1760,9 +1760,9 @@ function SMARTBUFF_BuffUnit(unit, subgroup, mode, spell)

SMARTBUFF_CheckUnitBuffTimers(unit);

if (UnitExists(unit) and UnitIsFriend("player", unit) and not UnitIsDeadOrGhost(unit) and not UnitIsCorpse(unit) and (UnitInRange(unit) or unit == "player")
and UnitIsConnected(unit) and UnitIsVisible(unit) and not UnitOnTaxi(unit) and not cBlacklist[unit] and ((not UnitIsPVP(unit) and (not isPvP or O.BuffPvP))
or (UnitIsPVP(unit) and (isPvP or O.BuffPvP)))) then
if (UnitExists(unit) and UnitIsFriend("player", unit) and not UnitIsDeadOrGhost(unit) and not UnitIsCorpse(unit) and (UnitInRange(unit) or unit == "player" or unit == "target"))
and UnitIsConnected(unit) and UnitIsVisible(unit) and not UnitOnTaxi(unit) and not cBlacklist[unit] and ((not UnitIsPVP(unit) and (not isPvP or O.BuffPvP)) or (UnitIsPVP(unit)
and (isPvP or O.BuffPvP))) then

_, uc = UnitClass(unit);
un = UnitName(unit);
Expand Down
8 changes: 4 additions & 4 deletions SmartBuff.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1733,7 +1733,7 @@
</Frame>
<Frame name="SmartBuff_BuffSetup" hidden="true" parent="SmartBuffOptionsFrame" toplevel="true" frameStrata="DIALOG" enableMouse="true">
<Size>
<AbsDimension x="213" y="800" />
<AbsDimension x="213" y="770" />
</Size>
<Anchors>
<Anchor point="TOPLEFT" relativeTo="SmartBuffOptionsFrame" relativePoint="TOPRIGHT">
Expand Down Expand Up @@ -2977,7 +2977,7 @@
</Frame>
<Frame name="SmartBuff_PlayerSetup" hidden="true" parent="SmartBuffOptionsFrame" toplevel="true" frameStrata="DIALOG" enableMouse="true">
<Size>
<AbsDimension x="160" y="800" />
<AbsDimension x="160" y="770" />
</Size>
<Anchors>
<Anchor point="TOPLEFT" relativeTo="SmartBuff_BuffSetup" relativePoint="TOPRIGHT">
Expand Down Expand Up @@ -3156,7 +3156,7 @@
</Frame>
<Frame name="SmartBuffWNF" hidden="true" parent="UIParent" toplevel="true" movable="true" frameStrata="DIALOG" enableMouse="true">
<Size>
<AbsDimension x="360" y="800" />
<AbsDimension x="360" y="770" />
</Size>
<Anchors>
<Anchor point="TOPLEFT" relativeTo="SmartBuffOptionsFrame" relativePoint="TOPRIGHT">
Expand All @@ -3168,7 +3168,7 @@
<Frames>
<EditBox name="$parent_lblText" multiLine="true" autoFocus="false">
<Size>
<AbsDimension x="313" y="740" />
<AbsDimension x="313" y="730" />
</Size>
<Anchors>
<Anchor point="TOPLEFT" relativeTo="$parent" relativePoint="TOPLEFT">
Expand Down
25 changes: 5 additions & 20 deletions localization.en.lua
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,11 @@
SMARTBUFF_WHATSNEW = "\n\n|cffffffff Whats new:|r\n\n"
.." |cffffffffClassic version by Codermik, additional retail coding\n"
.." by Speedwaystar.\n\n\n"
.." Changes in r41.200523:\n\n"
.." * Classic versions now use the codebase from the\n"
.." retail version with other additional changes to\n"
.." correctly work under this client.\n\n"
.." * Added prompt to do a GUI reload when new versions\n"
.." release to ensure addon is initialised correctly.\n\n"
.." * Added support for a mage's conjured food, water\n"
.." and their mana gems.\n\n"
.." * Added support for hunters call/revive pet.\n\n"
.." * Added more missing food and consumables, please\n"
.." report if you find anything not showing up.\n\n"
.." * Added automatic gathering switcher toggled by\n"
.." alt-left clicking minimap icon or in options.\n\n"
.." * Tons of fixes, too many to mention here.\n\n\n"
.." Changes in r42.210523:\n\n"
.." * In addition to above released yesterday, Ive \n"
.." added an option to automatically switch off\n"
.." the automatic tracking switch in raids etc.\n\n"
.." * Added check for fishing rod in party/raids.\n\n"
.." * Added missing Lesser Invisibility for Warlocks.\n\n\n"
.." Changes in r43.210523:\n\n"
.." * Fixed frame scaling issues, i.e. the buff window\n"
.." and player windows were larger than the options\n"
.." screen... my o.c.d was killing me :)\n\n"
.." * Fixed target buffing - needs further testing.\n"
.."\n"
.." |cffffff00I currently play on the Mirage Raceway EU\n"
.." classic WOTLK server as Alliance, I play Mik,\n"
Expand Down

0 comments on commit b0e199e

Please sign in to comment.