DATAGO-59386: Fix NPE when calling api/v2/ema/scan REST API #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
slunelsolace
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
When a scan has been recently initiated, calling the api/v2/ema/scan API would result in a NPE
How was this change implemented?
When a scan is started, the scan status was not initialized. This fix initializes the scan status for each scan type to INITIATED.
How was this change tested?
Manual tested by initiating a scan and calling the scan API directly afterwards.
Also added an automated test that asserts the scan type is initialized as expected.
Is there anything the reviewers should focus on/be aware of?
No