DATAGO-65659: Add terraform assets to the docker build #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmeldrum
commented
Dec 5, 2023
| @@ -7,6 +7,6 @@ | |||
| @Service | |||
| @Data | |||
| public class TerraformProperties { | |||
| @Value("${plugins.terraform.workingDirectoryRoot:/${HOME}/tfconfig}") | |||
There was a problem hiding this comment.
Remove the unneeded leading / character.
moodiRealist
approved these changes
Dec 6, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Add the terraform assets to docker since we do not want the user to have to do any setup themselves.
How was this change implemented?
Added the terraform executable and solace provider to the docker directory and the Dockerfile adds them to the image and sets up the path
How was this change tested?
Tested in docker on Windows, Linux and MacOS. Manually sent a mop message to trigger queue/subscription creation, update and deletion.
Is there anything the reviewers should focus on/be aware of?
No