Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAGO-64298: send config push logs to eVMR #138

Merged

Conversation

moodiRealist
Copy link
Collaborator

@moodiRealist moodiRealist commented Dec 7, 2023

What is the purpose of this change?

Send EMA logs during config push to a new topic in eVMR.

How was this change implemented?

Introduced a new commandLog processor and publisher to publish logs to a new topic.

How was this change tested?

ITs and manually:
Screenshot 2023-12-07 at 4 28 57 PM

Is there anything the reviewers should focus on/be aware of?

Nope.

Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 59.8% 59.8% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@moodiRealist moodiRealist marked this pull request as ready for review December 7, 2023 21:30
Copy link
Collaborator

@gregmeldrum gregmeldrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@moodiRealist moodiRealist merged commit 7d1879c into main Dec 8, 2023
5 of 6 checks passed
@mo-radwan1 mo-radwan1 deleted the moodiRealist/DATAGO-64298-send-configPush-logs-to-ep branch May 7, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants