-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAGO-64298: send config push logs to eVMR #138
Merged
moodiRealist
merged 6 commits into
main
from
moodiRealist/DATAGO-64298-send-configPush-logs-to-ep
Dec 8, 2023
Merged
DATAGO-64298: send config push logs to eVMR #138
moodiRealist
merged 6 commits into
main
from
moodiRealist/DATAGO-64298-send-configPush-logs-to-ep
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodiRealist
had a problem deploying
to
build_pr
December 7, 2023 14:53
— with
GitHub Actions
Failure
moodiRealist
commented
Dec 7, 2023
.../src/main/java/com/solace/maas/ep/event/management/agent/publisher/CommandLogsPublisher.java
Outdated
Show resolved
Hide resolved
gregmeldrum
reviewed
Dec 7, 2023
...ation/src/main/java/com/solace/maas/ep/event/management/agent/logging/StreamingAppender.java
Show resolved
Hide resolved
gregmeldrum
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
mo-radwan1
deleted the
moodiRealist/DATAGO-64298-send-configPush-logs-to-ep
branch
May 7, 2024 18:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Send EMA logs during config push to a new topic in eVMR.
How was this change implemented?
Introduced a new commandLog processor and publisher to publish logs to a new topic.
How was this change tested?
ITs and manually:
Is there anything the reviewers should focus on/be aware of?
Nope.