DATAGO-81660: event-management-agent Dockerfile must account for correct user and user home directory setup #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
rudraneel-chakraborty
changed the title
| @@ -1,8 +1,20 @@ | |||
| ARG BASE_IMAGE | |||
| FROM ${BASE_IMAGE} | |||
|
|
|||
| # default user name is "emauser" | |||
| ARG USER=emauser | |||
There was a problem hiding this comment.
Note: you can override the username by --build-arg USER=someuser
moodiRealist
approved these changes
Aug 13, 2024
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
rudraneel-chakraborty
had a problem deploying
to
build_pr
GitHub Actions
Error
|
|
||
| COPY .terraformrc /root/.terraformrc | ||
| # switch to the created user from root | ||
| USER $USER |
There was a problem hiding this comment.
This is the earliest we can switch to user as line 24 requires to use apk
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
rudraneel-chakraborty
deleted the
DATAGO-81660-use-dedicated-user-dockerfile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Implement asks of https://sol-jira.atlassian.net/browse/DATAGO-81660
How was this change implemented?
By changing the docker file
emauser(Note: the username can be overiddeen by passing the arfument to the Dockerfile).terraformrcfile is copied to the/home/emauserdirectoryemauserHow was this change tested?
Tested configpush and scan for :
Is there anything the reviewers should focus on/be aware of?