-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAGO-84853: cema config push resiliency #211
Open
mynecker
wants to merge
17
commits into
main
Choose a base branch
from
mynecker/DATAGO-84853-CEMA-ConfigPush-Resiliency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1f2a242
added semp delete command support for dangling resources removal
mynecker d8b8957
added semp delete command support for dangling resources removal
mynecker 692a6bf
fixed IT tests
mynecker 907609c
fixed IT tests
mynecker 20a8b90
fixed IT tests
mynecker 97bb783
fixed IT tests
mynecker e1162e3
fixed IT test
mynecker e0be1d3
excluded sempv2 generated client from jacoco test coverage checking
mynecker 7ea0d89
added IT and unit tests
mynecker c1f6f97
added IT and unit tests
mynecker 2874ce8
added IT and unit tests
mynecker bd8931f
refactoring and cleanup
mynecker 7647a60
fixed IT tests
mynecker 17449ef
streamlined CommandManager error handling
mynecker 49628f1
fixed SempDeleteCommandManager
mynecker 8005d74
fixed code style and dependency
mynecker 39328ad
fixed tests
mynecker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...lication/src/main/java/com/solace/maas/ep/common/model/SempAclProfileDeletionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.solace.maas.ep.common.model; | ||
|
||
import lombok.Builder; | ||
import lombok.Data; | ||
|
||
@Data | ||
@Builder | ||
public class SempAclProfileDeletionRequest { | ||
private String msgVpn; | ||
private String aclProfileName; | ||
} |
15 changes: 15 additions & 0 deletions
15
...ain/java/com/solace/maas/ep/common/model/SempAclPublishTopicExceptionDeletionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package com.solace.maas.ep.common.model; | ||
|
||
import lombok.Builder; | ||
import lombok.Data; | ||
|
||
@Data | ||
@Builder | ||
public class SempAclPublishTopicExceptionDeletionRequest { | ||
private String msgVpn; | ||
private String aclProfileName; | ||
/** | ||
* The topic string to be deleted from the ACL exception list - may include wild cards | ||
*/ | ||
private String publishTopic; | ||
} |
16 changes: 16 additions & 0 deletions
16
...n/java/com/solace/maas/ep/common/model/SempAclSubscribeTopicExceptionDeletionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.solace.maas.ep.common.model; | ||
|
||
import lombok.Builder; | ||
import lombok.Data; | ||
|
||
@Data | ||
@Builder | ||
public class SempAclSubscribeTopicExceptionDeletionRequest { | ||
|
||
private String msgVpn; | ||
private String aclProfileName; | ||
/** | ||
* The topic string to be deleted from the ACL exception list - may include wild cards | ||
*/ | ||
private String subscribeTopic; | ||
} |
11 changes: 11 additions & 0 deletions
11
.../src/main/java/com/solace/maas/ep/common/model/SempAuthorizationGroupDeletionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.solace.maas.ep.common.model; | ||
|
||
import lombok.Builder; | ||
import lombok.Data; | ||
|
||
@Data | ||
@Builder | ||
public class SempAuthorizationGroupDeletionRequest { | ||
private String msgVpn; | ||
private String authorizationGroupName; | ||
} |
12 changes: 12 additions & 0 deletions
12
...tion/src/main/java/com/solace/maas/ep/common/model/SempClientUsernameDeletionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package com.solace.maas.ep.common.model; | ||
|
||
import lombok.Builder; | ||
import lombok.Data; | ||
|
||
@Data | ||
@Builder | ||
public class SempClientUsernameDeletionRequest { | ||
|
||
private String msgVpn; | ||
private String clientUsername; | ||
} |
11 changes: 11 additions & 0 deletions
11
service/application/src/main/java/com/solace/maas/ep/common/model/SempEntityType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.solace.maas.ep.common.model; | ||
|
||
public enum SempEntityType { | ||
solaceQueue, | ||
solaceAclProfile, | ||
solaceAclSubscribeTopicException, | ||
solaceAclPublishTopicException, | ||
solaceClientUsername, | ||
solaceAuthorizationGroup, | ||
solaceQueueSubscriptionTopic | ||
} |
11 changes: 11 additions & 0 deletions
11
...e/application/src/main/java/com/solace/maas/ep/common/model/SempQueueDeletionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.solace.maas.ep.common.model; | ||
|
||
import lombok.Builder; | ||
import lombok.Data; | ||
|
||
@Data | ||
@Builder | ||
public class SempQueueDeletionRequest { | ||
private String msgVpn; | ||
private String queueName; | ||
} |
12 changes: 12 additions & 0 deletions
12
.../main/java/com/solace/maas/ep/common/model/SempQueueTopicSubscriptionDeletionRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package com.solace.maas.ep.common.model; | ||
|
||
import lombok.Builder; | ||
import lombok.Data; | ||
|
||
@Builder | ||
@Data | ||
public class SempQueueTopicSubscriptionDeletionRequest { | ||
private String topicName; | ||
private String queueName; | ||
private String msgVpn; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add some exclusions on jacoco reports on ep-core PR as well. Please make sure we will pass the line coverage requirements before merging this PR.