Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protected route 추가 #96

Merged
merged 2 commits into from
Oct 16, 2024
Merged

protected route 추가 #96

merged 2 commits into from
Oct 16, 2024

Conversation

qaws7791
Copy link
Contributor

@qaws7791 qaws7791 commented Oct 10, 2024

#45
private 경로에 대한 권한은 profile api 성공 여부로 판단. 어떻게 개선하는 게 좋을까요

@qaws7791 qaws7791 requested a review from yeojini October 10, 2024 14:04
@yeojini
Copy link
Contributor

yeojini commented Oct 11, 2024

어느부분에서 고민이신건가요?

@qaws7791
Copy link
Contributor Author

userProfile을 가져오기 전까지는 null 값을 반환해서 차단된다는 것? 미들웨어에서 인증을 처리 하는 게 아니면 어쩔 수 없는 부분인 것 같기도 해요

@yeojini
Copy link
Contributor

yeojini commented Oct 14, 2024

네 미들웨어 안쓰면 어쩔수없을것같습니다!

@qaws7791 qaws7791 merged commit d9bbf90 into main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants