Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAR-24127 Document 2025.1 LTA breaking changes #622

Conversation

carminevassallo
Copy link
Collaborator

@carminevassallo carminevassallo commented Jan 10, 2025

Copy link
Collaborator

@jCOTINEAU jCOTINEAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good to me!

Copy link
Contributor

@vilchik-elena vilchik-elena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carminevassallo I left some minor comments

charts/sonarqube-dce/README.md Outdated Show resolved Hide resolved
charts/sonarqube/README.md Outdated Show resolved Hide resolved
charts/sonarqube/README.md Outdated Show resolved Hide resolved
@carminevassallo carminevassallo enabled auto-merge (squash) January 10, 2025 10:35
@davividal
Copy link
Collaborator

@carminevassallo is the monitoringPasscode still base64 encoded?

I think we also need this, right?

diff --git a/charts/sonarqube-dce/README.md b/charts/sonarqube-dce/README.md
index 2355f73..3647b1b 100644
--- a/charts/sonarqube-dce/README.md
+++ b/charts/sonarqube-dce/README.md
@@ -546,7 +546,7 @@ The following table lists the configurable parameters of the SonarQube chart and
 | Parameter                      | Description                                                                                                                              | Default          |
 | ------------------------------ | ---------------------------------------------------------------------------------------------------------------------------------------- | ---------------- |
 | `sonarqubeFolder`              | (DEPRECATED) Directory name of SonarQube, Due to 1-1 mapping between helm version and docker version, there is no need for configuration | `/opt/sonarqube` |
-| `monitoringPasscode`           | Value for sonar.web.systemPasscode needed for LivenessProbes (encoded to Base64 format).                                                 | `None`           |
+| `monitoringPasscode`           | Value for sonar.web.systemPasscode needed for LivenessProbes                                                                             | `None`           |
 | `monitoringPasscodeSecretName` | Name of the secret where to load `monitoringPasscode`                                                                                    | `None`           |
 | `monitoringPasscodeSecretKey`  | Key of an existing secret containing `monitoringPasscode`                                                                                | `None`           |
 | `extraContainers`              | Array of extra containers to run alongside the `sonarqube` container (aka. Sidecars)                                                     | `[]`             |
diff --git a/charts/sonarqube/README.md b/charts/sonarqube/README.md
index 4899b46..4747e65 100644
--- a/charts/sonarqube/README.md
+++ b/charts/sonarqube/README.md
@@ -462,7 +462,7 @@ The following table lists the configurable parameters of the SonarQube chart and
 | `sonarProperties`              | Custom `sonar.properties` key-value pairs (e.g., "sonarProperties.sonar.forceAuthentication=true")                                       | `None`           |
 | `sonarSecretProperties`        | Additional `sonar.properties` key-value pairs to load from a secret                                                                      | `None`           |
 | `sonarSecretKey`               | Name of existing secret used for settings encryption                                                                                     | `None`           |
-| `monitoringPasscode`           | Value for sonar.web.systemPasscode needed for LivenessProbes (encoded to Base64 format)                                                  | `None`           |
+| `monitoringPasscode`           | Value for sonar.web.systemPasscode needed for LivenessProbes                                                                             | `None`           |
 | `monitoringPasscodeSecretName` | Name of the secret where to load `monitoringPasscode`                                                                                    | `None`           |
 | `monitoringPasscodeSecretKey`  | Key of an existing secret containing `monitoringPasscode`                                                                                | `None`           |
 | `extraContainers`              | Array of extra containers to run alongside the `sonarqube` container (aka. Sidecars)                                                     | `[]`             |

@carminevassallo carminevassallo force-pushed the doc/cv/SONAR-24127-add-lta-section-with-breaking-changes branch from 9623000 to d9b4365 Compare January 20, 2025 08:15
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@carminevassallo carminevassallo merged commit 5f2bec0 into master Jan 20, 2025
12 checks passed
@carminevassallo carminevassallo deleted the doc/cv/SONAR-24127-add-lta-section-with-breaking-changes branch January 20, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants