SONAR-24220 Set a new GCP-Service-name annotation #629
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
carminevassallo
changed the title
carminevassallo
force-pushed
the
task/cv/fix-gcp-service-name
branch
8 times, most recently
from
515a417 to
eb1dd6c
Compare
carminevassallo
force-pushed
the
task/cv/fix-gcp-service-name
branch
from
eb1dd6c to
fdb92b9
Compare
|
carminevassallo
changed the title
|
The last commit is only to trigger the job for review. It will get removed after the acceptance. |
jCOTINEAU
approved these changes
Feb 4, 2025
| @@ -1,7 +1,7 @@ | |||
| build_gcp_app_template: &BUILD_GCP_APP_TEMPLATE | |||
| ec2_instance: | |||
| <<: *VM_TEMPLATE | |||
| skip: "!changesInclude('charts/sonarqube-dce/*', 'charts/sonarqube-dce/**/*', 'google-cloud-marketplace-k8s-app/*', 'google-cloud-marketplace-k8s-app/**/*', 'tests/unity-compatibility-test/sonarqube-dce/*', '.cirrus/*.sh', '.cirrus/tasks{_sonarqube_dce,_templates,_gcp_marketplace,}.yml', '.cirrus/tasks.star', '.cirrus.star')" | |||
| #skip: "!changesInclude('charts/sonarqube-dce/*', 'charts/sonarqube-dce/**/*', 'google-cloud-marketplace-k8s-app/*', 'google-cloud-marketplace-k8s-app/**/*', 'tests/unity-compatibility-test/sonarqube-dce/*', '.cirrus/*.sh', '.cirrus/tasks{_sonarqube_dce,_templates,_gcp_marketplace,}.yml', '.cirrus/tasks.star', '.cirrus.star')" | |||
There was a problem hiding this comment.
this probably needs to be uncommented ? or do you think we should rework it ?
| - docker tag ${GCLOUD_REGISTRY}/${GCLOUD_PRODUCT_NAME}/deployer:${CURRENT_MINOR_VERSION} ${GCLOUD_REGISTRY}/${GCLOUD_PRODUCT_NAME}/deployer:${GCLOUD_TAG} | ||
| - docker push ${GCLOUD_REGISTRY}/${GCLOUD_PRODUCT_NAME}/deployer:${GCLOUD_TAG} | ||
| - docker push ${GCLOUD_REGISTRY}/${GCLOUD_PRODUCT_NAME}/deployer:${CURRENT_MINOR_VERSION} | ||
| - docker buildx create --driver=docker-container --use |
There was a problem hiding this comment.
just noticed this --driver option that was not there in this pr SonarSource/docker-sonarqube#742 (review)
is it required ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONAR-24220