Create rule S7195: PySpark lit(None) should be used when populating empty columns #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
joke1196
changed the title
joke1196
force-pushed
the
rule/add-RSPEC-S7195
branch
from
54179e8 to
fbb298d
Compare
thomas-serre-sonarsource
approved these changes
Feb 3, 2025
rules/S7195/python/rule.adoc
Outdated
|
|
||
| == Why is this an issue? | ||
|
|
||
| In PySpark, when populating a DataFrame columns with empty or null values, it is recommended to use `lit(None)`. |
There was a problem hiding this comment.
Suggested change
| In PySpark, when populating a DataFrame columns with empty or null values, it is recommended to use `lit(None)`. | |
| In PySpark, when populating a DataFrame column with empty or null values, it is recommended to use `lit(None)`. |
rules/S7195/python/metadata.json
Outdated
| "quickfix": "unknown", | ||
| "code": { | ||
| "impacts": { | ||
| "MAINTAINABILITY": "MEDIUM", |
There was a problem hiding this comment.
subjective May be I would remove maintainability or set it LOW, but it is really a matter of taste. As you wish!
Suggested change
| "MAINTAINABILITY": "MEDIUM", | |
| "MAINTAINABILITY": "LOW", |
There was a problem hiding this comment.
I think you are right! I am not sure it impacts the maintainability really.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: